-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub identity is persisted locally after log-out #13694
Comments
cc @vparfonov |
@artaleks9 can you update the issue with the information about the environment that was used? |
@ashumilova can you remind me what service dashboard is using to get a token? is this something from Che master side or it's communicating with Github directly? |
@skabashnyuk It uses our API method |
@ashumilova As I can see GitHub token is cached in LocalStorage. |
BTW any manipulation of user with github link to his kyecloak account will not be visible until this item exists in cache I think. |
@ashumilova shouldn't logout clear all the LocalStorage? |
It's whether not storing token in local storage(trying session storage), that is shared between user sessions, or adding additional data to differ user tokens. Not sure logout could be tracked in all use cases (expiration for example). |
Description
It seems logout from CHE doesn't include logout from GitHub.
The problem was detected in the beginning in the CRW (https://issues.jboss.org/browse/CRW-323)
Reproduction Steps
OS and version:
Environment: Openshift
7.0.0-rc-3.0-SNAPSHOT
Additional information:
The text was updated successfully, but these errors were encountered: