Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running any task fails after refresh #13799

Closed
tolusha opened this issue Jul 9, 2019 · 9 comments
Closed

Running any task fails after refresh #13799

tolusha opened this issue Jul 9, 2019 · 9 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach

Comments

@tolusha
Copy link
Contributor

tolusha commented Jul 9, 2019

Description

It is not possible to run a task after workspace is refreshed.

Reproduction Steps

  1. start workspace
  2. run any task
  3. It is possible to run a task
  4. refresh the tab
  5. run any task
  6. Error observed Can't get task launch configuration for label

OS and version:
minishift v1.34.0+f5db7cb
che-7.0.0-rc-3

Diagnostics:
Screenshot from 2019-07-09 10-09-12

Related issues:

#13155

@tolusha tolusha added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 9, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 9, 2019

@vparfonov @RomanNikitenko are you aware of this? Is it related to the tasks issues that you have in your sprint backlog or is it something new that we should add to milestone 7.0.0?

@l0rd l0rd added status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach team/ide labels Jul 9, 2019
@l0rd l0rd changed the title Can't get task launch configuration error after workspace is refreshed Running any task fails after refresh Jul 9, 2019
@RomanNikitenko
Copy link
Member

The bug was caused by changing in theia project way to define - is task detected or configured. I described the causes of the problem here. For che commands it will go away after merge eclipse-che/che-theia#295. But I'm going to update the PR and check again this case to be sure, I let you know ASAP.

@RomanNikitenko
Copy link
Member

I tested the case for eclipse-che/che-theia#295 and can not reproduced it. So I think the cause of the problem described here is correct.

@tolusha could you try to reproduce it:

  • using image rnikitenko/che-theia:7.0.0-task-fix
    or
  • using component in your devfile
- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/custom/meta.yaml
    type: cheEditor

The image contains:

Thank you!

@tolusha
Copy link
Contributor Author

tolusha commented Jul 15, 2019

@RomanNikitenko
With you image provided I can't run any tasks at all event without refreshing the browser.
The good news is that I can't reproduce this issue anymore with 7.0.0-rc-3.0 version of Che Theia.

@RomanNikitenko
Copy link
Member

@tolusha
I test it using the devfile:

apiVersion: 1.0.0
metadata:
 name: che
projects:
  - name: che-theia
    source:
      type: git
      location: 'https://github.com/eclipse/che-theia.git'
components:
  - 
    alias: che-dev
    type: dockerimage
    image: eclipse/che-theia-dev:next
    mountSources: true
    endpoints:
      - name: "theia-dev"
        port: 3130
        attributes:
          protocol: tcp
          public: 'true'
    memoryLimit: 4Gi
  - 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/RomanNikitenko/che-plugin-registry/master/v3/plugins/eclipse/che-theia/custom/meta.yaml
    type: cheEditor

commands:
- name: theia:build
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn
    workdir: /projects/che-theia

- name: theia:run:watch
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn build
    workdir: /projects/che-theia

che_version

Could you provide Help => About screenshot for your assembly?
Could you provide the way how did you test it?

@tolusha
Copy link
Contributor Author

tolusha commented Jul 15, 2019

It seems I can't run tasks from the My workspace panel using the image provided by @RomanNikitenko

@tolusha tolusha reopened this Jul 15, 2019
@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jul 15, 2019

It seems I tested a task form Terminal ===> Run Task menu, while Anatoly tested it from My workspace panel
@tolusha thank you, I'll check

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jul 17, 2019

@tolusha
I created the PR for 7.0.0 branch of che-theia project and provided How to test section.
Could you check your cases/devfiles?

Thanks in advance!

@RomanNikitenko
Copy link
Member

According to the eclipse-che/che-theia#355 (comment) should be fixed by eclipse-che/che-theia#355, so I'm closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach
Projects
None yet
Development

No branches or pull requests

3 participants