Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfiles in registry should not hard-code project name (when appropriate) #13936

Closed
amisevsk opened this issue Jul 19, 2019 · 3 comments
Closed
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@amisevsk
Copy link
Contributor

Is your task related to a problem? Please describe.

All of the currently deployed devfiles in the registry hard-code their project's path, e.g.

${CHE_PROJECTS_ROOT}/angular-realworld-example-app

This means that if a user adds any project to their workspace, the commands do not work (see #13594)

Describe the solution you'd like

Commands should be improved (where it is applicable) to use ${current.project.path}

For some devfiles this does not make sense, but it's worthwhile for "general" stacks such as python, java-maven, etc.

Describe alternatives you've considered

Leave it as-is, and treat devfiles in registry as "toy" samples that are difficult to modify.

Additional context

Depends on #13636

@amisevsk amisevsk added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Jul 19, 2019
@amisevsk amisevsk added this to the 7.x milestone Jul 19, 2019
@l0rd
Copy link
Contributor

l0rd commented Jul 22, 2019

@amisevsk note that we agreed with @ashumilova that if a user select a different project the commands should be dropped as well.

In other words, even if we do not hardcode the project path, there are good chances that the sample commands don't work for arbitrary users projects.

And the annoying issue with the macro ${current.project.path} is that it works only if the user select the project in the file explorer: commands fail otherwise. That's confusing for users.

@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@ericwill
Copy link
Contributor

Sounds like there is no way forward here, I'm going to close this ticket and we can open a new one when a viable solution is available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants