Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables are not resolved for execution of che commands #14031

Closed
5 of 23 tasks
RomanNikitenko opened this issue Jul 25, 2019 · 2 comments
Closed
5 of 23 tasks

Variables are not resolved for execution of che commands #14031

RomanNikitenko opened this issue Jul 25, 2019 · 2 comments
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@RomanNikitenko
Copy link
Member

RomanNikitenko commented Jul 25, 2019

Describe the bug

We have ability to define variables like ${file} for che commands in a devfile.
It works well for theia tasks, but doesn't work for che commands.

Che version

  • latest
  • nightly
  • other: che-theia:7.0.0-next

Steps to reproduce

  1. Use in devfile command like:
- name: copy content
  actions:
  - type: exec
    component: che-dev
    command: >
              cp ${workspaceFolder}/.theia/tasks.json ${workspaceFolder}/cheCommands.json
    workdir: /projects
  1. Run the task
  2. You can see that task can not be executed because the variable is not resolved

Expected behavior

The variable is resolved and the task is executed

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (v1.0.0)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Installation method

  • chectl chectl/0.0.2-6d3894f linux-x64 node-v10.4.1
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify
@RomanNikitenko RomanNikitenko added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 25, 2019
@RomanNikitenko RomanNikitenko changed the title Variables are not resolved for execution che commands Variables are not resolved for execution of che commands Jul 25, 2019
@RomanNikitenko RomanNikitenko added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 25, 2019
@RomanNikitenko
Copy link
Member Author

I created the PR for 7.0.0 branch, please let me know if this changes are assumed for 7.0.0.

@rhopp rhopp added status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. team/pm labels Jul 26, 2019
@slemeur slemeur added this to the 7.0.0 milestone Jul 26, 2019
@slemeur slemeur added team/ide severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. team/pm status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Jul 26, 2019
@slemeur
Copy link
Contributor

slemeur commented Jul 26, 2019

P2 but would be nice to include it in 7.0.0 as it will allow to solve the issue from #14007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants