Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possibility of not patching workspace language runtime images when running OpenShift v4 #14042

Closed
ibuziuk opened this issue Jul 26, 2019 · 1 comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jul 26, 2019

For Che 7 GA release we did patching of language runtime images to make them compatible with OpenShift - https://github.com/eclipse/che-devfile-registry/tree/master/arbitrary-users-patch

The arbitrary-users-patch was done as part of the #13454

Basically, for OpenShift v3 it looks like there is no other possibility other than patching which is described in the official documentation - https://docs.okd.io/3.11/creating_images/guidelines.html#openshift-specific-guidelines

However, it looks like the situation changed dramatically in OpenShift v4 - openshift/origin#23369

CRI-O is the default contianer engine in OpenShift v4 which has the support of adding the entry of the user to the /etc/password if it does not exists in /etc/passwd.

We need to investigate the possibility of not patching any language runtime images and use them as-is on OpenShift v4.

Describe the solution you'd like

Need to investigate the possibility of not patching any language runtime images and use them as-is on OpenShift v4

Describe alternatives you've considered

Alternatively, we would need to continue patching images as done for OpenShift v3 - https://github.com/eclipse/che-devfile-registry/tree/master/arbitrary-users-patch

The verification of the arbitrary-users-patch compatibility with OpenShift v4 was done in #13960

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/osio labels Jul 26, 2019
@ibuziuk ibuziuk added this to the 7.x milestone Jul 26, 2019
@ibuziuk ibuziuk modified the milestones: 7.x, Backlog - Hosted Che Oct 30, 2019
@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@che-bot
Copy link
Contributor

che-bot commented May 12, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot closed this as completed May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants