Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test C# theia plugin with multi-root workspace in Theia #14223

Closed
tsmaeder opened this issue Aug 14, 2019 · 4 comments
Closed

Test C# theia plugin with multi-root workspace in Theia #14223

tsmaeder opened this issue Aug 14, 2019 · 4 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@tsmaeder
Copy link
Contributor

We need to make sure omnisharp works ok with multi-root workspace, using version 0.0.4 from https://github.com/redhat-developer/omnisharp-theia-plugin/releases

@tsmaeder tsmaeder added kind/task Internal things, technical debt, and to-do tasks to be performed. team/languages labels Aug 14, 2019
@tsmaeder tsmaeder mentioned this issue Aug 14, 2019
24 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 14, 2019
@slemeur slemeur added this to the 7.1.0 milestone Aug 14, 2019
@slemeur slemeur removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 14, 2019
@tsmaeder
Copy link
Contributor Author

Did some tests, in particular:

  1. started a workspace with the C# and the suggested default project
  2. Dependencies are restores, language features work fine
  3. Switched to "multi-root" in the preferences
  4. Added some random folder as a second workspace root
  5. Refresh the browser to restart the IDE
  6. language features work fine
  7. Remove the default project as a workspace root
  8. Refresh the browser
  9. Add the project as a workspace root
  10. Observe: language features do not work in the project
  11. refresh the browser
  12. Observe language features work in the project

@tsmaeder
Copy link
Contributor Author

My conclusion is: the php plugin works with workspace roots, but it does not handle changing workspace roots. We would need that support in order to merge the fix for #13427.

@tsmaeder
Copy link
Contributor Author

Also, omnisharp can only handle one open solution at a time. Microsofts C# extension offers support to chose an "active" project (https://code.visualstudio.com/docs/languages/csharp#_roslyn-and-omnisharp). We don't seem to have that.

@tsmaeder
Copy link
Contributor Author

Opened issues to fix the problems uncovered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

3 participants