Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/ssh/generate should validate name. #14272

Closed
1 of 4 tasks
monaka opened this issue Aug 18, 2019 · 3 comments
Closed
1 of 4 tasks

/api/ssh/generate should validate name. #14272

monaka opened this issue Aug 18, 2019 · 3 comments
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/duplicate Issue identified as a duplicate of another issue

Comments

@monaka
Copy link
Member

monaka commented Aug 18, 2019

Describe the bug

After creating SSH keypair via API with unsuitable parameter, all workspaces can't boot up.

Che version

  • nightly

Steps to reproduce

  1. Open swagger.
  2. Call /api/ssh/generate with paramter { "name": "Non FQDN string as you like", "service": "vcs" }
  3. Boot up your workspace. It will be failed by naming issue on the K8s secret object.

Expected behavior

Unsuitable names should be rejected by /api/ssh/generate.

Runtime

  • other: (please specify) Runtime independent.

Installation method

  • I don't know Installation independent

Environment

  • other: please specify Environment independent.

Additional context

Related on #14243.

@monaka monaka added the kind/bug Outline of a bug - must adhere to the bug report template. label Aug 18, 2019
@monaka monaka added this to the 7.1.0 milestone Aug 18, 2019
@monaka
Copy link
Member Author

monaka commented Aug 18, 2019

I think this will be showstopper if the user set it. But it will be a rare case. So it isn't urgent (enough to be fixed after 7.0.0 released).

@gorkem
Copy link
Contributor

gorkem commented Aug 18, 2019

@monaka is this also related to #14218

@monaka
Copy link
Member Author

monaka commented Aug 19, 2019

@gorkem Yes. I close this and move to #14218.

@monaka monaka closed this as completed Aug 19, 2019
@monaka monaka added the status/duplicate Issue identified as a duplicate of another issue label Aug 19, 2019
@monaka monaka removed this from the 7.1.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/duplicate Issue identified as a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants