Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Che Theia build is broken #14618

Closed
mmorhun opened this issue Sep 20, 2019 · 3 comments
Closed

Che Theia build is broken #14618

mmorhun opened this issue Sep 20, 2019 · 3 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented Sep 20, 2019

Is your task related to a problem? Please describe.

After changes in upstream Eclipse Theia project build of Che Theia is broken.

From CI build log:

lerna ERR! [compile] src/node/plugin-remote-init.ts(214,52): error TS2339: Property 'stopContext' does not exist on type 'PluginHostRPC'.
lerna ERR! [compile] error Command failed with exit code 2.
lerna ERR! [compile] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! [compile] yarn compile exited with code 2

Additional context

Commit in Eclipse Theia which brought breaking changes: 50beaee
@mmorhun mmorhun added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Sep 20, 2019
@dmytro-ndp
Copy link
Contributor

Link to broken build log: https://ci.codenvycorp.com/job/che-theia-pullrequests-build/683/console

@nickboldt
Copy link
Contributor

nickboldt commented Sep 20, 2019 •
edited
Loading

73 files changed, one reviewer with unresolved feedback, merged on a Friday.

Short term, we could revert the change in the local checkout of Theia when building Che-theia?

@gorkem
Copy link
Contributor

gorkem commented Sep 20, 2019

+1 to take a Theia before that commit. I think that change has much more consequences than just a couple of renamed API. We should not release it on 7.2

@benoitf benoitf mentioned this issue Sep 23, 2019
Closed
23 tasks
@evidolob evidolob mentioned this issue Sep 24, 2019
Merged
@evidolob evidolob mentioned this issue Sep 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gorkem @nickboldt @evidolob @dmytro-ndp @mmorhun