Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plug-ins of extension packs for all default stacks #15272

Open
4 tasks
benoitf opened this issue Nov 21, 2019 · 12 comments
Open
4 tasks

Use plug-ins of extension packs for all default stacks #15272

benoitf opened this issue Nov 21, 2019 · 12 comments
Labels
area/plugin-registry area/samples kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@benoitf
Copy link
Contributor

benoitf commented Nov 21, 2019

Description

When using VS Code (or VS Code online) and when I'm working on a Java project the default java pack is proposed https://marketplace.visualstudio.com/items?itemName=vscjava.vscode-java-pack

It includes vscode-java and the debugger but also a lot of other tools like the java test runner, dependency viewer, maven scaffolding, etc.

This is also true for different technologies
https://marketplace.visualstudio.com/search?target=VSCode&category=Extension%20Packs&sortBy=Installs

There are PHP pack, Python pack, TypeScript, etc.

But in Che, there is mostly only the LSP/Debug extension provided while tons of tools are de-factory really important when working on a project.

Describe the solution you'd like

I would like to have the same default plug-ins/packs provided when using Che and working for a given technology.

Java Devfile example --> Java Extension Pack being selected.
PHP Devfile example --> PHP Extension pack being selected.
etc.

dependency tasks:

Check plug-ins are working tasks:

@benoitf benoitf added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. area/languages Issues related to Language extensions or plugins integration. labels Nov 21, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 21, 2019
@benoitf benoitf added this to the Backlog - Languages milestone Nov 21, 2019
@benoitf benoitf changed the title Use of extension packs used for all default stacks Use of extension packs for all default stacks Nov 21, 2019
@tsmaeder
Copy link
Contributor

This is a good idea, but we don't have the notion of "extension packs" for Che plugins. This needs some technical thought.
Also, this sounds largish; should it be included in the roadmap? https://github.com/eclipse/che/wiki/Roadmap

@tsmaeder tsmaeder added severity/P2 Has a minor but important impact to the usage or development of the system. kind/enhancement A feature request - must adhere to the feature request template. area/editor/theia Issues related to the che-theia IDE of Che area/plugin-registry status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Nov 21, 2019
@benoitf
Copy link
Contributor Author

benoitf commented Nov 21, 2019

AFAIK it's largish as it's an epic

@tsmaeder
Copy link
Contributor

Since the implementation of this is unclear, not sure which team to assign this to. @benoitf @l0rd this needs some discussion first.

@tsmaeder tsmaeder removed this from the Backlog - Languages milestone Nov 25, 2019
@tsmaeder
Copy link
Contributor

Removed from language backlog, not clear this falls into our responsibilities.

@benoitf
Copy link
Contributor Author

benoitf commented Nov 25, 2019

@tsmaeder it's your responsability

It's only about adding more default plug-ins for default stack languages.

@benoitf benoitf removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Nov 25, 2019
@benoitf benoitf added this to the Backlog - Languages milestone Nov 25, 2019
@tsmaeder
Copy link
Contributor

@benoitf that's not what the title says.

@benoitf
Copy link
Contributor Author

benoitf commented Nov 25, 2019

In Eclipse Che, right now if I select Java, java-debug vsix is also brought.
So ChePlugin can bring more than one vsix at a time (which is what an extension pack is doing)

so I could have a ChePlugin with the exact same list of vsix (minor the one that are not free) for a given language

so it's just a matter of bringing more plug-ins to have same experience than on VS Code or Vs Code Online

@benoitf benoitf changed the title Use of extension packs for all default stacks Use plug-ins of extension packs for all default stacks Nov 25, 2019
@tsmaeder
Copy link
Contributor

@benoitf no, if I have two extension packs (let's say "Quarkus" and "Spring Boot"), I'll end up with multiple copies of jdt.ls. So this is not simply a matter of adding more VS Code extensions to the Che plugins. If the user installs two of them, stuff is going to break. Having a "extension pack" mechanism is much more involved and is unlikely to even involve the "languages" team.

@benoitf
Copy link
Contributor Author

benoitf commented Nov 25, 2019

@tsmaeder if you don't provide extension as separate plug-in it doesn't reproduce your problem.
And AFAIK quarkus is not included in the Java extension pack

@benoitf
Copy link
Contributor Author

benoitf commented Nov 25, 2019

I think we should separate issue
This issue/epic is about having one plug-in that is enabling multiple plug-ins at a time (same container)

Not trying to solve the issue about enabling 4 different plug-ins and make them work with the same container or by sharing a common folder for jdt.ls

Or not trying to solve plug-in collision.

Just to have same default tools than VS Code online that enable by default the extension pack for projects. (so need to be sure that these extensions are working well)

@benoitf benoitf removed this from the Backlog - Languages milestone Nov 25, 2019
@benoitf
Copy link
Contributor Author

benoitf commented Nov 25, 2019

I will create specific issues for Languages Team ans list them in the epic

@slemeur slemeur removed the kind/enhancement A feature request - must adhere to the feature request template. label Jan 7, 2020
@benoitf benoitf added team/controller and removed area/editor/theia Issues related to the che-theia IDE of Che labels Jan 8, 2020
@tsmaeder tsmaeder added this to the Backlog - Languages milestone Jan 23, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 4, 2021
@l0rd l0rd added the roadmap/1-year Epics that are planned to complete in the short term (12 months or more) label Mar 26, 2021
@l0rd l0rd added area/samples and removed area/languages Issues related to Language extensions or plugins integration. roadmap/1-year Epics that are planned to complete in the short term (12 months or more) labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry area/samples kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

8 participants