Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist plugin and editors home folder to keep configuration after workspace restart. #15421

Closed
sunix opened this issue Dec 6, 2019 · 8 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.

Comments

@sunix
Copy link
Contributor

sunix commented Dec 6, 2019

Is your enhancement related to a problem? Please describe.

Many vscode extension and editors are storing some settings in /home/theia.
At the moment, some settings like workspace roots, kubernetes context are lost after restart.

Describe the solution you'd like

Maybe have a volume for /home/theia.

@sunix sunix added the kind/enhancement A feature request - must adhere to the feature request template. label Dec 6, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 6, 2019
@tolusha tolusha added the status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. label Dec 8, 2019
@tolusha
Copy link
Contributor

tolusha commented Dec 8, 2019

All plugins have a dedicated path to persist theirs state. [1]

@evidolob
Is it /home/theia ?

[1] https://github.com/microsoft/vscode/blob/1.40.2/src/vs/vscode.d.ts#L4972-L4989

@tolusha tolusha removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 31, 2020
@sunix
Copy link
Contributor Author

sunix commented Feb 5, 2020

@tolusha I don't think we need more info to prioritize this ... this is to the assignee to make an analysis and see what would be needed.

@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che severity/P1 Has a major impact to usage or development of the system. and removed status/info-needed More information is needed before the issue can move into the “analyzing” state for engineering. labels Feb 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@ericwill
Copy link
Contributor

Haven't we fixed this for Kube/oc/tekton with the /home/.kube volume?

@che-bot che-bot closed this as completed Sep 9, 2020
@tsmaeder tsmaeder reopened this Oct 29, 2020
@PirateBread
Copy link

I would also add that persisting a users $HOME directory would make a lot of sense. Many CLI tools will store various configuration items, for example various .dotfiles and folders. Wondering if anyone has attempted to configure a container with Eclipse Che to work this way?

Lots of virtual terminal offerings do this, for example if you use GCP/Azure CLI, it will store your home directory in a persistent way and for users it works as they expect. For example if they update a .bashrc or .zshrc configuration or store your kubectl config.

@che-bot che-bot closed this as completed Jan 4, 2021
@sunix
Copy link
Contributor Author

sunix commented Jan 29, 2021

/remove-lifecycle stale

@sunix sunix reopened this Jan 29, 2021
@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2021
@ericwill ericwill added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Feb 1, 2021
@AObuchow
Copy link

AObuchow commented Jun 5, 2023

This is now being implemented as part of #22102.

@l0rd do you think we can close this issue? It should be encompassed by #22102, and this issue was more specifically directed towards Theia.

@l0rd
Copy link
Contributor

l0rd commented Jun 5, 2023

@AObuchow yes let's close this one as we are already tracking the same problem in the most up to date #22102

@l0rd l0rd closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

9 participants