Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and replace in multiple files #1564

Closed
wernight opened this issue Jun 23, 2016 · 10 comments
Closed

Search and replace in multiple files #1564

wernight opened this issue Jun 23, 2016 · 10 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@wernight
Copy link

Could you add support to search & replace in all files below a directory, or all open files, allowing regex. Basically the current find and replace but for mutliple files (like Sublime Text allows).

@ddementieva ddementieva added the kind/enhancement A feature request - must adhere to the feature request template. label Jun 23, 2016
@wernight
Copy link
Author

wernight commented Jun 23, 2016

I heard from some people that it's actually possible (but couldn't say how). Can anyone confirm or refute?

@slemeur
Copy link
Contributor

slemeur commented Jun 23, 2016

Hi @wernight.

Currently, you can:

  • find&replace in the current file
  • find in all files below a directory
  • find usages of a java class

See the gif:
find

Your request is a bit different from what is provided in Che for now. So it is considered as an enhancement.

@davidwindell
Copy link
Contributor

Bulk find and replace saves a lot of time in Netbeans, this feature is what our dev's miss most.

@wernight
Copy link
Author

@slemeur I'm aware of the search. As you pointed out, there is no replace in multiple files.

@slemeur
Copy link
Contributor

slemeur commented May 16, 2017

@wernight. You are right, the replace is available only in the current file.

Along with a bigger work on the UI, we are considering to replace the current search capabilities.
Once we'll have a specification drafted, it will be shared here and your comments will be helpful (as the ones you gave for git ;) ).

@wernight
Copy link
Author

I'd suggest to work like Sublime Text (and most modern text editors):

image

@davidwindell
Copy link
Contributor

davidwindell commented May 22, 2017

Netbeans is nice too, especially how it shows all the replaces done afterwards in a list and their line numbers (although that's a bigger feature needed with Che's search at the moment).

screenshot from 2017-05-22 13-35-16

Here's the best part of it, you can select exactly which files you want to replace

screenshot from 2017-05-25 13-35-49

@slemeur
Copy link
Contributor

slemeur commented May 22, 2017

Thank you guys.
Similarly to what we did for the Git panel, we will consider to use a left panel for the search/replace.
Hopefully, I'll have a spec on that soon.

@wernight
Copy link
Author

I feel this isn't like Git. This is about editing locally so it's what you're doing already.

A dialog here, like for Git, would be good for a one time complex action.

Having a side bar is also good, just I'd make it as close as possible to the simple find in file. Having few visual differences makes the UI simpler to understand. Since the in-file search (and replace) are in the top-left, I'd probably just have the search & replace there as well if going for an inline option (like the side bar).

@slemeur
Copy link
Contributor

slemeur commented Jul 2, 2019

Fixed in Che 7

@slemeur slemeur closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

5 participants