Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral toggle is confusing #15721

Closed
maxandersen opened this issue Jan 16, 2020 · 13 comments · Fixed by #15818
Closed

Ephemeral toggle is confusing #15721

maxandersen opened this issue Jan 16, 2020 · 13 comments · Fixed by #15818
Labels
area/dashboard good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template.

Comments

@maxandersen
Copy link

maxandersen commented Jan 16, 2020

Normal users don't know what Ephemeral mode means (nor should they) and the help text is not helping.

2020-01-16_11-50-11

What is a PVC ?

Suggestion:
Call it something like Temporary Storage or Persistent Disk Volume or something that at least gives a normal human a chance to guess what that toggle is about.

@maxandersen maxandersen added the kind/bug Outline of a bug - must adhere to the bug report template. label Jan 16, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 16, 2020
@ibuziuk ibuziuk added team/hosted-che kind/enhancement A feature request - must adhere to the feature request template. good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! and removed team/hosted-che kind/enhancement A feature request - must adhere to the feature request template. kind/bug Outline of a bug - must adhere to the bug report template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 16, 2020
@ibuziuk ibuziuk added this to the Backlog - Hosted Che milestone Jan 16, 2020
@sleshchenko sleshchenko modified the milestones: Backlog - Hosted Che, Backlog - Controller Jan 20, 2020
@sleshchenko
Copy link
Member

Proposed toggle title: Temporary Storage,
Message for pop-up: Temporary Storage allows containers to share volumes but they are not persisted (all the data will be lost after workspace restart)

If someone has any suggestions/remarks - p.lease comment here

@ibuziuk
Copy link
Member

ibuziuk commented Jan 20, 2020

@maxandersen WDYT ^ ?

@maxandersen
Copy link
Author

Muuch better :)

btw. another thing that i'm not sure if this tooltip is the right place for - it seems with temporary storage you also end up with less space than with a persistent one...like a basic gradle build like jbang can't run on temporary storage but it can when not chosen.

@ibuziuk
Copy link
Member

ibuziuk commented Jan 20, 2020

it seems with temporary storage you also end up with less space than with a persistent one.

yeah, good point but storage size for ephemeral is a separate issue that requires more investigation. I believe for the next release we can start with just improving the naming / tooltip

@maxandersen
Copy link
Author

Agreed @ibuziuk just not sure where to report this "quirk" that I assume is very deployment specific. if you can let me know I'll open issue for it.

@ibuziuk
Copy link
Member

ibuziuk commented Jan 20, 2020

@maxandersen this one is cluster / config specific, so please open it against https://github.com/redhat-developer/rh-che/issues

@beaumorley
Copy link

Can we say something in the tool tip about why they would keep it turned on? If we just say their data will be lost, will users turn it off? What about something with a positive spin like this (guessing here as to why they may want to keep it on):

Temporary Storage [toggle control here]
Tooltip: Temporary Storage allows for faster I/O but is not persistent. All data will be lost after the workspace restarts.

@beaumorley
Copy link

What about?

Temporary Storage allows for faster I/O but has limited storage and is not persistent.

@maxandersen
Copy link
Author

I think the limited storage is very much dependent on the underlying cluster configuration so it would not be true in all installations.

That’s at least how I understand the current situation.

@beaumorley
Copy link

Hmm. Is this too complicated for a tooltip? Is it accurate?


Temporary Storage allows for faster I/O. It may have limited storage for certain configurations and is not persistent.


I feel like the original second sentence (All data will be lost after the workspace restarts.) is redundant. So I suggest removing that and expanding on Max's pain point.

@beaumorley
Copy link

beaumorley commented Jan 23, 2020

Here are some mockups of how the updated ephemeral toggle might look. For the existing UI, change the label and the tooltip copy. This will need to be done on the New Workspace screen and the Workspace > Overview screen. Like this:

image

image

For the new getting started page, I recommend do something like this:

image

  • Move search control to the left
  • Put the toggle next to the number of items

@sleshchenko
Copy link
Member

New wording on Create Workspace and Workspace Details are already addressed in #15818

There is a separate issue to introduce Temporary Storage on Get Started page #15855

@SDAdham
Copy link

SDAdham commented Mar 5, 2020

Can we have a clarification on what is the use case for it? When do we need to toggle it on? It still doesn't really clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard good first issue Community, this issue looks easy to start with for a new contributor. Just take it. We'll help you! kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants