Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devfile not found when factory constructed with .git suffix #16109

Closed
1 of 23 tasks
mshaposhnik opened this issue Feb 24, 2020 · 1 comment
Closed
1 of 23 tasks

Devfile not found when factory constructed with .git suffix #16109

mshaposhnik opened this issue Feb 24, 2020 · 1 comment
Assignees
@mshaposhnik
Labels
area/factory/server Server side of factory implementation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone
7.10

Comments

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Feb 24, 2020 •
edited by sparkoo
Loading

Describe the bug

When factory url is constructed with .git suffix, e.g. https://che.openshift.io/f?url=https://github.com/jchraibi/nodejs-ex.git&policies.create=peruser there is 2 problems appears:

  1. Devfile is not found by che server, despite the fact it is present in repo;
  2. As a consequence of 1), default project source is constructed and has double suffix .git.git

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Expected behavior

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Additional context
@mshaposhnik mshaposhnik added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 24, 2020
@mshaposhnik mshaposhnik self-assigned this Feb 24, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 24, 2020
@skabashnyuk skabashnyuk added team/platform area/factory/server Server side of factory implementation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 24, 2020
@skabashnyuk skabashnyuk added this to the 7.10.0 milestone Feb 24, 2020
@ibuziuk
Copy link
Member

ibuziuk commented Feb 24, 2020

@l0rd @nickboldt AFAIK, this is a must-have for 7.9.1

@mshaposhnik mshaposhnik changed the title Devfile not found when factory constaructed with .git suffix Devfile not found when factory constructed with .git suffix Feb 25, 2020
@mshaposhnik mshaposhnik mentioned this issue Feb 25, 2020
Merged
@nickboldt nickboldt mentioned this issue Feb 26, 2020
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshaposhnik mshaposhnik

Labels
area/factory/server Server side of factory implementation kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.10
Development

No branches or pull requests
4 participants
@ibuziuk @skabashnyuk @mshaposhnik @che-bot