Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any URI that gives SVG/PNG image to be used for plugin icon #16894

Closed
vitaliy-guliy opened this issue May 12, 2020 · 0 comments
Closed
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@vitaliy-guliy
Copy link
Contributor

Describe the bug

I'm adding Che Buildkit plugin #16539, which adds the buildkit-base container to Che workspace.
But there is no special logo image for the buildkit. In this case it's a good option is to use the organization logo.

moby

Organization: https://github.com/moby
Buildkit repository: https://github.com/moby/buildkit

For that, we need to disable checking of the plugin image and use the value form plugin meta.yaml as it is.

If the plugin meta.yaml refers to a non-existent image, the frontend application should use the default one. I think that handling of such kind of errors is already implemented in Dashboard and Che-Theia.

Connected with #14502

@vitaliy-guliy vitaliy-guliy added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins labels May 12, 2020
@vitaliy-guliy vitaliy-guliy self-assigned this May 12, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 12, 2020
@mshaposhnik mshaposhnik added area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants