Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML LS can't start #17381

Closed
1 of 3 tasks
azatsarynnyy opened this issue Jul 13, 2020 · 1 comment · Fixed by eclipse-che/che-theia#813
Closed
1 of 3 tasks

HTML LS can't start #17381

azatsarynnyy opened this issue Jul 13, 2020 · 1 comment · Fixed by eclipse-che/che-theia#813
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Jul 13, 2020

Describe the bug

HTML Language Server is provided to Che Theia though the VS Code built-in extension
https://github.com/eclipse/che-theia/blob/727b6c5a1e650a1357652610b48482a9cc5c9bae/generator/src/templates/theiaPlugins.json#L20

When opening any HTML file, Che Theia shows the error notifications, see the attached screenshots.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

Open any HTML file in Che Theia.

Expected behavior

HTML language features as an autocomplete, hovers, etc. should be provided.

Screenshots

image

Eclipse Che Logs

From HTML Language Server output channel:

internal/modules/cjs/loader.js:638
    throw err;
    ^

Error: Cannot find module 'typescript'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:636:15)
    at Function.Module._load (internal/modules/cjs/loader.js:562:25)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:473959)
    at n (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:158)
    at Object.<anonymous> (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:520451)
    at n (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:158)
    at Object.<anonymous> (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:38535)
    at n (/default-theia-plugins/vscode-builtin-html-language-features/extension/server/dist/htmlServerMain.js:1:158)
[Error - 10:08:00 AM] Connection to server got closed. Server will not be restarted.

Additional context

Note, s.languages.registerOnTypeRenameProvider is not a function is a known upstream issue eclipse-theia/theia#7987. Despite that error, HTML LS starts in upstream Theia.

I've tried with several different versions of html-language-features and the result is the same.

First, need to check this path https://github.com/microsoft/vscode/blob/182db07de2745fe3a6369f4ad80ae930e006a99b/extensions/html-language-features/server/src/modes/javascriptLibs.ts#L12

@azatsarynnyy azatsarynnyy added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. area/editor/theia Issues related to the che-theia IDE of Che labels Jul 13, 2020
@shahar-h
Copy link

See: eclipse-theia/theia#8224

@RomanNikitenko RomanNikitenko self-assigned this Jul 23, 2020
@RomanNikitenko RomanNikitenko added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 23, 2020
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 30, 2020
@azatsarynnyy azatsarynnyy mentioned this issue Aug 3, 2020
10 tasks
@azatsarynnyy azatsarynnyy added this to the 7.17 milestone Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants