Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che-theia: Webview resources within non-theia sidecars return 404 #17931

Closed
gattytto opened this issue Sep 22, 2020 · 3 comments
Closed

Che-theia: Webview resources within non-theia sidecars return 404 #17931

gattytto opened this issue Sep 22, 2020 · 3 comments
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/editors kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@gattytto
Copy link

gattytto commented Sep 22, 2020

if you check the screenshot, extensions that need to serve files directly and use a sidecar return 404 errors for resources that are contained outside of the theia sidecar filesystem.

I guess this could be solved by adding workaround volume for theia in the devfile, but this is something that will be always required by certain extensions (like plantUML), so I think it would be better to add an extra property in plugin yaml volumes, like:

apiVersion: v2
publisher: gattytto
name: plantuml
version: 2.13.13
type: VS Code extension
displayName: PlantUML
title: PlantUML support
description: This extension adds support for the PlantUML Server
icon: https://github.com/gattytto/vscode-plantuml/raw/master/images/icon.png
repository: https://github.com/gattytto/vscode-plantuml
category: Language
firstPublicationDate: '2020-09-22'
spec:
  containers:
    - image: "quay.io/eclipse/che-sidecar-plantuml:2.13.13-ee2987c"
      name: vscode-plantuml
      memoryLimit: '512Mi'
      volumes:
        - mountPath: "/tmp/vscode-unpacked"
          name: "previewassets"
          **alsoMountInTheia: true**
  extensions:
    - https://github.com/gattytto/vscode-plantuml/releases/download/2.13.13/plantuml-2.13.13.vsix

image

@gattytto gattytto added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 22, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 22, 2020
@gattytto
Copy link
Author

also changing the UML code really auto-updates the preview which is neat!

@ericwill ericwill added area/editor/theia Issues related to the che-theia IDE of Che area/editors severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 22, 2020
@gattytto
Copy link
Author

gattytto commented Oct 7, 2020

in haskell:
this case we need jwt-proxy-webviews service to look for those files straight into the sidecar filesystem (and not in theia's), folders that are filled previously in the Dockerfile build stage.

In the plantUML extension case I think this is not required because the extension "fills" the content when it's initialized so it won't matter if setting the volume in extension meta.yaml erases the folder's content to have it available bot in sidecar and theia-ide container filesystem and it's just a couple files anyways.
image

@azatsarynnyy
Copy link
Member

duplication of #16870

@gattytto gattytto closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che area/editors kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants