Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] When clicking "Run" nothing happens unless a java file is open / extension is loaded #18004

Closed
l0rd opened this issue Sep 30, 2020 · 2 comments
Assignees
Labels
area/languages Issues related to Language extensions or plugins integration. area/ux Issues related to User Experience Design kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 30, 2020

Describe the bug

Clicking "Start Debugging" or "Start Without Debugging" from Theia Debug menu has no effects until the Java extension is not activated:

image

Clicking on those items AFTER opening a Java file (and the Java extension has started) does have an effect.

Che version

che.openshift.io

Steps to reproduce

  1. Go to che.openshift.io
  2. Click on the Quarkus Tools stack
  3. Wait for the workspace to start
  4. Click "Start Debugging" or "Start Without Debugging" from Theia Debug menu

Expected behavior

If no event is hooked to a menu item, then that item should be disabled.

@l0rd l0rd added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 30, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 30, 2020
@nickboldt nickboldt changed the title When clicking "Run" nothing happens [UX] When clicking "Run" nothing happens unless a java file is open / extension is loaded Oct 1, 2020
@nickboldt nickboldt added the area/ux Issues related to User Experience Design label Oct 1, 2020
@ericwill ericwill added area/languages Issues related to Language extensions or plugins integration. severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 5, 2020
@ericwill ericwill mentioned this issue Nov 18, 2020
34 tasks
@ericwill ericwill added this to the 7.23 milestone Nov 18, 2020
@ericwill ericwill mentioned this issue Dec 3, 2020
34 tasks
@ericwill ericwill modified the milestones: 7.23, 7.24 Dec 8, 2020
@sunix sunix self-assigned this Jan 6, 2021
@nickboldt nickboldt modified the milestones: 7.24, 7.25 Jan 8, 2021
@ericwill ericwill mentioned this issue Jan 14, 2021
33 tasks
@sunix
Copy link
Contributor

sunix commented Jan 18, 2021

Hello,
The path I have chosen was to see if we could from che-theia,

  1. detect a debug port activation
  2. change the Start Debug command enablement according to that.

so 1. is done in port plugin

For 2. I try to see if we could override an existing command enablement from a plugin or a theia extension. but it looks like it is not possible. https://github.com/eclipse-theia/theia/blob/master/packages/core/src/common/command.ts is not providing a way to override an existing command.

@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2021
@che-bot che-bot closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. area/ux Issues related to User Experience Design kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants