Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git commit hot key doesn't work #18067

Closed
4 of 22 tasks
vinokurig opened this issue Oct 7, 2020 · 0 comments · Fixed by eclipse-theia/theia#8606
Closed
4 of 22 tasks

Git commit hot key doesn't work #18067

vinokurig opened this issue Oct 7, 2020 · 0 comments · Fixed by eclipse-theia/theia#8606
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Oct 7, 2020

Describe the bug

Git commit hot key (CTRL + ENTER) doesn't work

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Open a workspace with some project cloned from GitHub and make some changes.
  2. Open the SCM panel and stage the changes.:
    screenshot-github com-2020 10 07-16_33_54
  3. Type a commit message and press CTRL + ENTER
  4. Nothing happens, error appears in the browser console:
theia.ab78b42b15f4a780a919.js:1 root ERROR Failed to execute command: TypeError: Converting circular structure to JSON
    --> starting at object with constructor 'e'
    |     property 'next' -> object with constructor 'e'
    --- property 'prev' closes the circle
    at JSON.stringify (<anonymous>)
    at Function.e.request (https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:766707)
    at e.remoteCall (https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:763789)
    at Proxy.n.<computed>.r.charCodeAt.n.<computed> (https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:763192)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:1224824
    at e.<anonymous> (https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:2975515)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:2965542
    at Object.next (https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:2965647)
    at https://static.developers.redhat.com/che/theia_artifacts/theia.ab78b42b15f4a780a919.js:1:2964559
    at new Promise (<anonymous>)

Expected behavior

A new commit must be added.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Eclipse Che Logs

Additional context

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins labels Oct 7, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 7, 2020
@ericwill ericwill mentioned this issue Oct 7, 2020
27 tasks
@vinokurig vinokurig self-assigned this Oct 7, 2020
@ericwill ericwill added this to the 7.21 milestone Oct 7, 2020
@benoitf benoitf added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants