Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plug-in registry has valid data when building image #18747

Closed
benoitf opened this issue Jan 6, 2021 · 4 comments
Closed

Ensure plug-in registry has valid data when building image #18747

benoitf opened this issue Jan 6, 2021 · 4 comments
Assignees
Labels
area/plugin-registry area/qe kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Milestone

Comments

@benoitf
Copy link
Contributor

benoitf commented Jan 6, 2021

Is your enhancement related to a problem? Please describe.

Some releases had in the meta.yaml some images that did not exist.
It should not happen, release should break in case of invalid images

Describe the solution you'd like

Check that OCI images referenced by generated meta.yaml are valid

Describe alternatives you've considered

N/A

Additional context

Fail fast will guarantee that we're not pushing invalid resources.

@benoitf benoitf added kind/enhancement A feature request - must adhere to the feature request template. area/plugin-registry labels Jan 6, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 6, 2021
@ericwill
Copy link
Contributor

ericwill commented Jan 8, 2021

There could be a post-build step in the release that checks each meta.yaml for:

  • valid sidecar, if one is defined
  • valid icon
  • valid repository
  • valid vsix link

@sleshchenko sleshchenko added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 11, 2021
@ericwill ericwill mentioned this issue Jan 14, 2021
33 tasks
@ericwill ericwill added this to the 7.26 milestone Jan 20, 2021
@ericwill
Copy link
Contributor

Also, there is a script calling skopeo and fetching the digest -- we should make this part of the build process and fail the release if any of the digests/tags are invalid.

@sunix
Copy link
Contributor

sunix commented Jan 28, 2021

@ericwill
Copy link
Contributor

See eclipse/che-plugin-registry#814 (comment)
Should be fixed with eclipse/che-plugin-registry#815

Closing as the PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry area/qe kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
6 participants