Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or update globalMemoryLimit in devfiles' meta.yaml #19464

Closed
svor opened this issue Mar 30, 2021 · 5 comments
Closed

Remove or update globalMemoryLimit in devfiles' meta.yaml #19464

svor opened this issue Mar 30, 2021 · 5 comments
Assignees
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@svor
Copy link
Contributor

svor commented Mar 30, 2021

Is your task related to a problem? Please describe.

I don't see any reason to have globalMemoryLimit attribute in devfile's meta.yaml like this https://github.com/eclipse-che/che-devfile-registry/blob/master/devfiles/dotnet/meta.yaml#L6

Describe the solution you'd like

If this field isn't used, let's go through all devfiles and remove globalMemoryLimit from meta.yaml

Describe alternatives you've considered

If it used somewhere need to validate this value for each devfile.

@svor svor added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins severity/P2 Has a minor but important impact to the usage or development of the system. area/devfile-registry labels Mar 30, 2021
@benoitf
Copy link
Contributor

benoitf commented Mar 30, 2021

related to devfile/api#361

@nickboldt
Copy link
Contributor

nickboldt commented Mar 30, 2021

Sounds like this is related to the fix we did in redhat-developer/devspaces#455 to move memory limits from devfiles and into plugins.

For multi-arch support of Che on IBM Power, this is a must-have requirement, as ppc64le needs more ram than amd64 or s390x, so needs to be able to override defaults in the plugin registry and NOT have those overrides limited by devfiles setting lower limits.

@ericwill
Copy link
Contributor

+1 to removing it, we have plenty of tools available when it comes to memory limits (plugin definitions, devfiles). I do not think we need a third one.

@l0rd
Copy link
Contributor

l0rd commented Mar 31, 2021

Today we do not have a mechanism to tell the user that they should NOT try to run a Java stack on a 4GB or less Kubernetes node. That was a first step to try to setup that mechanism.

But as of today we are not using it and we are not maintaining that information. At this stage it's better to remove it.

@ericwill
Copy link
Contributor

Fixed by eclipse-che/che-devfile-registry#379

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants