Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the "che-plugin-registry" image build using multistage dockerfile #19554

Closed
Ohrimenko1988 opened this issue Apr 9, 2021 · 5 comments
Closed
Assignees
Labels
area/plugin-registry area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@Ohrimenko1988
Copy link
Contributor

Is your task related to a problem? Please describe.

Currently, building of the "che-plugin-registry" requires preinstalled tools on the local machine:

  • nodejs
  • yarn
  • git

In my opinion it would be great to rework the current flow for using multi-stage docker flow.
It gives us several advantages:

  • We will get rid of pre-build steps, all necessary tools will be already in the container
  • Reduce the possibility of local environment issues
  • Keep the image small

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@Ohrimenko1988 Ohrimenko1988 added kind/task Internal things, technical debt, and to-do tasks to be performed. area/qe area/plugin-registry labels Apr 9, 2021
@Ohrimenko1988 Ohrimenko1988 self-assigned this Apr 9, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Apr 9, 2021
@yhontyk yhontyk added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Apr 9, 2021
@ericwill ericwill mentioned this issue Apr 9, 2021
42 tasks
@ericwill ericwill added this to the 7.30 milestone Apr 14, 2021
@benoitf
Copy link
Contributor

benoitf commented Apr 15, 2021

it should not be a 'pure multi-stage' Dockerfile, but also publish both 'dev image' and a 'build image'
dev image allows 'dogfooding usage'

@benoitf
Copy link
Contributor

benoitf commented Apr 15, 2021

BTW we already have the dev-image

@ericwill ericwill mentioned this issue Apr 29, 2021
32 tasks
@ericwill ericwill modified the milestones: 7.30, 7.31 May 4, 2021
@ericwill ericwill mentioned this issue May 20, 2021
29 tasks
@ericwill ericwill modified the milestones: 7.31, 7.32 May 20, 2021
@ericwill ericwill removed this from the 7.32 milestone Jun 10, 2021
@ericwill ericwill mentioned this issue Jun 10, 2021
30 tasks
@ericwill ericwill mentioned this issue Jun 30, 2021
22 tasks
@svor svor removed the sprint/next label Jul 8, 2021
@svor svor mentioned this issue Jul 22, 2021
34 tasks
@svor svor mentioned this issue Aug 12, 2021
30 tasks
@svor svor removed the sprint/next label Aug 18, 2021
@svor svor mentioned this issue Sep 7, 2021
26 tasks
@che-bot
Copy link
Contributor

che-bot commented Mar 7, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 7, 2022
@che-bot che-bot closed this as completed Mar 14, 2022
@svor svor reopened this Mar 31, 2022
@svor svor removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 31, 2022
@che-bot
Copy link
Contributor

che-bot commented Sep 27, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2022
@svor svor removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2022
@che-bot
Copy link
Contributor

che-bot commented Jun 7, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2023
@che-bot che-bot closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin-registry area/qe kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

7 participants