Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt the Secrets plugin API to use kubernetes secrets #19837

Closed
vinokurig opened this issue May 20, 2021 · 1 comment · Fixed by eclipse-che/che-theia#1166
Closed

Adapt the Secrets plugin API to use kubernetes secrets #19837

vinokurig opened this issue May 20, 2021 · 1 comment · Fixed by eclipse-che/che-theia#1166
Assignees
@vinokurig
Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Milestone
7.35

Comments

@vinokurig
Copy link
Contributor

Is your task related to a problem? Please describe.

The Secrets plugin API is going to be merged soon to theia. It uses keytar to store data in the local file system. This approach will not work for Che because workspaces are containers with new OS each time they restart, so the data will go away on restart.

Describe the solution you'd like

Reimplement the CredentialsService to use kubernetes secrets.

Describe alternatives you've considered

Additional context
@vinokurig vinokurig added kind/task Internal things, technical debt, and to-do tasks to be performed. team/plugins area/plugins labels May 20, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label May 20, 2021
@ericwill ericwill added sprint/next and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels May 20, 2021
@ericwill ericwill mentioned this issue May 20, 2021
Closed
29 tasks
@ericwill ericwill added this to the 7.32 milestone May 20, 2021
@ericwill ericwill modified the milestones: 7.32, 7.33 Jun 10, 2021
@ericwill ericwill mentioned this issue Jun 10, 2021
Closed
30 tasks
@ericwill ericwill mentioned this issue Jun 30, 2021
Closed
22 tasks
@vinokurig
Copy link
Contributor Author

I faced with a problem: create secret request to kubernetes fails because of the permissions restrictions: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"secrets is forbidden: User \"system:serviceaccount:admin-che:che-workspace\" cannot create resource \"secrets\" in API group \"\" in the namespace \"admin-che\"","reason":"Forbidden","details":{"kind":"secrets"},"code":403}
@benoitf any ideas?

@vinokurig vinokurig mentioned this issue Jul 6, 2021
Merged
9 tasks
@svor svor removed the sprint/next label Jul 8, 2021
This was referenced Jul 9, 2021
Merged
Merged
@vinokurig vinokurig mentioned this issue Jul 20, 2021
Merged
9 tasks
@svor svor modified the milestones: 7.33, 7.34 Jul 20, 2021
@svor svor mentioned this issue Jul 22, 2021
Closed
34 tasks
@svor svor removed the sprint/next label Jul 28, 2021
@vinokurig vinokurig mentioned this issue Jul 28, 2021
Closed
11 tasks
@vinokurig vinokurig mentioned this issue Jul 28, 2021
Merged
9 tasks
@svor svor modified the milestones: 7.34, 7.35 Aug 11, 2021
@svor svor mentioned this issue Aug 12, 2021
Closed
30 tasks
@amisevsk amisevsk mentioned this issue Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/plugins kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current
Projects
None yet
Milestone
7.35
Development

Successfully merging a pull request may close this issue.

fix: Adapt the Secrets plugin API to use kubernetes secrets eclipse-che/che-theia
4 participants
@svor @ericwill @vinokurig @che-bot