Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic connection to the OpenShift cluster when using the OpenShift connector (no need to login for the user anymore) #20857

Closed
Tracked by #20830
svor opened this issue Dec 1, 2021 · 4 comments
Closed
Tracked by #20830

Automatic connection to the OpenShift cluster when using the OpenShift connector (no need to login for the user anymore) #20857

svor opened this issue Dec 1, 2021 · 4 comments
Assignees
@vinokurig
Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Milestone
7.43

Comments

@svor
Copy link
Contributor

svor commented Dec 1, 2021 •
edited by l0rd
Loading

When devWorksapce is enabled, the k8s configuration file should be injected into each container - #20782.

So, in devWorkspace we don't need openshift-authentication-plugin to login into the cluster.

When devWorkspace engine is enabled, we have to provide another che plugin vscode-openshift-connector without che-openshift-authentication-plugin: https://github.com/eclipse-che/che-plugin-registry/blob/main/che-theia-plugins.yaml#L361-L379

Releases Notes Text

Users OpenShift connection token gets automatically injected in the workspace pods as startup and the OpenShift Connector VS Code extension leverages that now. This was already working with the Che server and we have aligned the DevWorkspace based workspaces too.
@svor svor mentioned this issue Dec 1, 2021
Closed
3 tasks
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 1, 2021
@svor svor changed the title openshift-auth - we won't need this plugin when k8s configuration will be automatically injected into the containers. Adapt openshift-authentication-plugin to avoid requesting che-server API in devWorkspace Dec 1, 2021
@svor svor changed the title Adapt openshift-authentication-plugin to avoid requesting che-server API in devWorkspace Adapt openshift-authentication plugin to avoid requesting che-server API in devWorkspace Dec 1, 2021
@svor svor added area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. team/plugins sprint/current and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 1, 2021
@svor svor added the severity/P1 Has a major impact to usage or development of the system. label Dec 1, 2021
@svor svor mentioned this issue Dec 1, 2021
Closed
41 tasks
@svor svor changed the title Adapt openshift-authentication plugin to avoid requesting che-server API in devWorkspace [devWorkspace ] Adapt openshift-authentication plugin to avoid requesting che-server API Dec 1, 2021
@svor svor mentioned this issue Dec 15, 2021
Closed
@svor svor mentioned this issue Dec 20, 2021
Closed
15 tasks
@benoitf
Copy link
Contributor

benoitf commented Dec 21, 2021

moving issue to 7.42 milestone as this issue is part of the endgame

@svor svor removed the sprint/next label Dec 22, 2021
@svor svor changed the title [devWorkspace ] Adapt openshift-authentication plugin to avoid requesting che-server API [devWorkspace ] Adapt openshift-connector plugin to avoid requesting che-server API Jan 10, 2022
@svor svor mentioned this issue Jan 11, 2022
Closed
17 tasks
@svor
Copy link
Contributor Author

svor commented Jan 12, 2022

.kube/config file was injected into containers, tested on OpenShift:

screenshot-che-eclipse-che apps ci-ln-mz81l9b-72292 origin-ci-int-gce dev rhcloud com-2022 01 12-11_24_38

@svor svor modified the milestones: 7.42, 7.43 Jan 12, 2022
@vinokurig vinokurig mentioned this issue Jan 14, 2022
Merged
9 tasks
@svor
Copy link
Contributor Author

svor commented Jan 14, 2022 •
edited
Loading

I've created followup issue for CRW: https://issues.redhat.com/browse/CRW-2640

@svor svor closed this as completed Jan 14, 2022
@l0rd l0rd changed the title [devWorkspace ] Adapt openshift-connector plugin to avoid requesting che-server API Automatic connection to the OpenShift cluster when using the OpenShift connector (no need to login for the user anymore) Jan 19, 2022
@l0rd l0rd added new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording labels Jan 19, 2022
@devstudio-release
Copy link

sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-2684

@max-cx max-cx removed the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/plugins engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
7.43
Development

No branches or pull requests
7 participants
@benoitf @l0rd @svor @vinokurig @devstudio-release @che-bot @max-cx