Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che operator should propagate an env varialble START_OPENVSX to the plugin registry #21611

Closed
Tracked by #20549
l0rd opened this issue Aug 4, 2022 · 0 comments
Closed
Tracked by #20549
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github.
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Aug 4, 2022

Is your enhancement related to a problem? Please describe

The plugin registry is going to embed an OpenVSX instance (including postgres) and can require up to 1.5GB.

But if the admin configures Che to use an external OpenVSX Registry (i.e. specifies pluginRegistry.openVSXURL in the CheCluster) Che is still starting the embedded OpenVSX instance.

The embedded OpenVSX Registry should not be started if the user has specified pluginRegistry.openVSXURL.

Describe the solution you'd like

  • Che operator should propagate the START_OPENVSX env variable (through a ConfigMap) to the plugin registry container
  • The env variable should be set to true if the user hasn't specified a pluginRegistry.openVSXURL, set to false otherwise.
  • The Plugin registry should start the openVSX instance if START_OPENVSX is set to true and should not start if the env variable is set to false or doesn't exist.
@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator labels Aug 4, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 4, 2022
@tolusha tolusha closed this as completed Aug 5, 2022
@tolusha tolusha added this to the 7.52 milestone Aug 5, 2022
@tolusha tolusha mentioned this issue Aug 5, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/enhancement A feature request - must adhere to the feature request template. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github.
Projects
None yet
Development

No branches or pull requests

3 participants