Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dashboard 'Not allowed to start more workspace' message could be confusing if workspace creation step is completed #21672

Closed
dkwon17 opened this issue Aug 30, 2022 · 2 comments
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Aug 30, 2022

Is your enhancement related to a problem? Please describe

Currently, when the user tries to start a new workspace when the user already has the maximum allowable number of concurrent running workspaces (set by admin by setting spec.components.devWorkspace.runningLimit in the Che CR), the user will see this message from the dashboard:

image

Describe the solution you'd like

This message might be a bit confusing because we can see in the UI that step 2 Creating a workspace has been completed. Workspace creation might imply that the workspace/editor exists and is accessible, when it is not (since the workspace has not started).

A possible solution is to make it clear that workspace creation and workspace startup are separate actions from the error message.

For example, instead of You are not allowed to start more workspaces, it could be The workspace was created, but it cannot be started because you have reached the maximum running workspaces limit.

It is important to note that this new message would only make sense when the user starts a new workspace, not an existing one.

Describe alternatives you've considered

A different solution could be to not create the workspace at all if the running workspaces limit is reached.

Additional context

Would be great if the error message also displayed what the maximum workspace running limit is: #21669

@dkwon17 dkwon17 added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 30, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Aug 30, 2022
@azatsarynnyy azatsarynnyy added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Aug 30, 2022
@che-bot
Copy link
Contributor

che-bot commented Feb 26, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2023
@che-bot che-bot closed this as completed Mar 5, 2023
@dkwon17 dkwon17 reopened this Mar 6, 2023
@dkwon17 dkwon17 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 6, 2023
@akurinnoy
Copy link
Contributor

This issue was fixed in eclipse-che/che-dashboard#841

Screenshot from the dogfooding cluster:

Screenshot 2024-02-21 at 10 41 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants