Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Error Message When Trying to Run Che Server Twice #2233

Closed
JamesDrummond opened this issue Aug 26, 2016 · 3 comments
Closed

Modify Error Message When Trying to Run Che Server Twice #2233

JamesDrummond opened this issue Aug 26, 2016 · 3 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@JamesDrummond
Copy link
Contributor

Should we change the error message when trying to run che server if it is already running.

Reproduction Steps:

  1. docker run --rm -t -v /var/run/docker.sock:/var/run/docker.sock eclipse/che start
  2. docker run --rm -t -v /var/run/docker.sock:/var/run/docker.sock eclipse/che start

movie

Expected behavior:

Error message stating to run docker run --rm -t -v /var/run/docker.sock:/var/run/docker.sock eclipse/che stop.

Observed behavior:

Error message stating to run docker rm -f che-server.

[Describe observed behavior here]

Che version: nightly-4.7
OS and version: Ubuntu 16.04.1 LTS
Docker version:
Client:
Version: 1.11.2
API version: 1.23
Go version: go1.6.2
Git commit: b9f10c9
Built: Thu, 16 Jun 2016 21:17:51 +1200
OS/Arch: linux/amd64
Che install:
Google Cloud.

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: [Yes/No] No
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes/No] Yes
@TylerJewell
Copy link

This is expected behavior.

@JamesDrummond
Copy link
Contributor Author

If the server is shutdown with docker rm -f che-server certain files will not be saved. I know sometimes docker run --rm -t -v /var/run/docker.sock:/var/run/docker.sock eclipse/che stop will not work sometimes if the che server container is not responsive. Would putting both messages make sense. I meant to put both in expected behavior. Might be that I restart che server more then the average user though :).

@TylerJewell
Copy link

Good point. I added this to the che-launcher. Should show up in nightly by end of the week. Here is the new output.

ERROR: !!!
ERROR: !!!
           A container running ECLIPSE CHE named "che-server" already exists.
             1. Use "info" to find it's URL.
             2. Use "restart" to stop it and start anew.
             3. Stop it with "stop".
             4. Remove it manually (docker rm -f che-server) and try again. Or:
             5. Set CHE_SERVER_CONTAINER_NAME to a different value and try again.
ERROR: !!!

@TylerJewell TylerJewell self-assigned this Aug 26, 2016
@TylerJewell TylerJewell added this to the 4.7.0 milestone Aug 26, 2016
@TylerJewell TylerJewell added the kind/enhancement A feature request - must adhere to the feature request template. label Aug 26, 2016
@bmicklea bmicklea mentioned this issue Aug 29, 2016
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

2 participants