Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard should show already created personal access tokens #22343

Closed
tolusha opened this issue Jul 4, 2023 · 1 comment · Fixed by eclipse-che/che-dashboard#852
Closed

Dashboard should show already created personal access tokens #22343

tolusha opened this issue Jul 4, 2023 · 1 comment · Fixed by eclipse-che/che-dashboard#852
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. sprint/next team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Milestone
7.71

Comments

@tolusha
Copy link
Contributor

tolusha commented Jul 4, 2023

Is your enhancement related to a problem? Please describe

If PATs have been already created manually (to be honest almost all of them have been already created manually manually), they have to be displayed in the Users preferences/Personal access tokens. Otherwise it feels like nothing configured.

Describe the solution you'd like

Dashboard should read and show all PATs Secrets.

[1] oc get secrets -n <NAMESPACE> -l app.kubernetes.io/part-of=che.eclipse.org,app.kubernetes.io/component=scm-personal-access-token
[2] https://www.eclipse.org/che/docs/stable/end-user-guide/using-a-git-provider-access-token/

Describe alternatives you've considered

No response

Additional context

No response
@tolusha tolusha added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Jul 4, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 4, 2023
@tolusha
Copy link
Contributor Author

tolusha commented Jul 4, 2023

The filter is not correct [1]
Take into account only two labels:

  • app.kubernetes.io/part-of=che.eclipse.org
  • app.kubernetes.io/component=scm-personal-access-token

[1] https://github.com/eclipse-che/che-dashboard/blob/main/packages/dashboard-backend/src/devworkspaceClient/services/personalAccessTokenApi/helpers.ts#L71

@olexii4 olexii4 mentioned this issue Jul 4, 2023
Merged
@tolusha tolusha added this to the 7.71 milestone Jul 4, 2023
@olexii4 olexii4 removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. sprint/next team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
7.71
Development

Successfully merging a pull request may close this issue.

fix: access token filter eclipse-che/che-dashboard
4 participants
@ibuziuk @tolusha @olexii4 @che-bot