Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default devfile during workspace startup based on 'ssh://' if devfile can not be retrieved by che-server #22488

Closed
2 tasks done
ibuziuk opened this issue Sep 6, 2023 · 6 comments
Assignees
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Sep 6, 2023

Is your enhancement related to a problem? Please describe

PR with initial SSH support implementation - eclipse-che/che-server#539
There are a few enhancements that need to be done as part of this issue:

  • if SSH URL points to the unsupported provider and che-server can not retrieve devfile, workspace should be started based on the default one (appropriate warning message should be shown on the workspace startup screen)
  • default devfile should be also used if SSH url points to the supported provider, but devfile still can not be retrieved (e.g. private repo, no OAuth / PAT are configured)

Describe the solution you'd like

N/A

Describe alternatives you've considered

No response

Additional context

Related issue - #22473

@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/che-server labels Sep 6, 2023
@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 6, 2023

@vinokurig @l0rd please, review
this is a follow up issue based on the comments from eclipse-che/che-server#539
I think we can close #22473 in favour of this issue

@l0rd
Copy link
Contributor

l0rd commented Sep 6, 2023

@vinokurig @l0rd please, review this is a follow up issue based on the comments from eclipse-che/che-server#539 I think we can close #22473 in favour of this issue

LGTM

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 25, 2023

@vinokurig please, make sure that the fixes are backported for 3.9

@vinokurig
Copy link
Contributor

checrry-picked to 7.74 d8991eafd1a49aec704fe618834d1d5e99eb6883

@nickboldt
Copy link
Contributor

Tracked downstream in https://issues.redhat.com/browse/CRW-4871

@ibuziuk
Copy link
Member Author

ibuziuk commented Sep 27, 2023

closing as done

@ibuziuk ibuziuk closed this as completed Sep 27, 2023
@ibuziuk ibuziuk moved this from Ready for Review to ✅ Done in Eclipse Che Team A Backlog Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants