Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent value of SCM provider name in the Personal Access Tokens list. #22802

Closed
vinokurig opened this issue Feb 2, 2024 · 0 comments · Fixed by eclipse-che/che-dashboard#1075
Assignees
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@vinokurig
Copy link
Contributor

Describe the bug

Oauth token secrets are generated with a random string instead of provider name in the token name annotation.

Che version

7.80@latest

Steps to reproduce

  1. Setup GitHub oauth.
  2. Start a workspace from the GitHub repository with a devfile.
  3. Go to dashboard -> User Preferences -> Personal Access Tokens.

See: a random string is displayed as provider name value:
screenshot-eclipse-che apps cluster-9zjxb dynamic redhatworkshops io-2024 02 02-14_35_52

Expected behavior

Proper provider name must be shown.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

I see several solutions:

  1. Fix the token name annotation on storing new token secrets. In this case the provider value will look like oauth2-github. The oauth2 prefix would be a flag to distinguish oauth tokens from PAT.
  2. Full refactoring of the personal access token flow by changing the token name annotation to provider name and adding a new annotation is oath token with a boolean flag. This would require a migration mechanism to support previously added token secrets.
@vinokurig vinokurig added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 2, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Feb 2, 2024
@ibuziuk ibuziuk added severity/P2 Has a minor but important impact to the usage or development of the system. area/che-server and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants