Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After revoke OAuth application the 'Authorization' indicator is still turned in 'User Preferences' Dashboard #22836

Closed
artaleks9 opened this issue Feb 21, 2024 · 6 comments · Fixed by eclipse-che/che-server#673
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@artaleks9
Copy link
Contributor

artaleks9 commented Feb 21, 2024

Describe the bug

When the OAtuh application is revoked on git provider side, the 'Authorization' indicator is left turned on Dashboard, that is a bug.
In the same time the Personal Access Token is properly deleted from <user>-namespace

IMPORTANT: the issue is relevant only for Gitlab and Bitbucket Server (oauth1 and oauth2).

Che version

7.81@latest

Steps to reproduce

  1. Deploy Che
  2. Configure git provider OAuth
  3. Start a workspace from the git repository with a devfile.
  4. Go to the Dashboard -> User Preferences -> Git Services -> Authorization indicator is turn on
  5. Go to git provider -> revoke OAuth application
  6. Go to the Dashboard -> User Preferences -> Git Services -> Authorization indicator is left turn on

Expected behavior

After revoke OAuth application on git provider side, the Authorization indicator should be turn off in User Preferences of Dashboard

Runtime

OpenShift

Screenshots

git-services-Eclipse-Che-User-Preferences
personal-access-token-Eclipse-Che-User-Preferences

Installation method

chectl/next

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@artaleks9 artaleks9 added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che labels Feb 21, 2024
@dmytro-ndp
Copy link
Contributor

The issue looks related to #22827, IMHO

@vinokurig
Copy link
Contributor

Duplicates #22790

@vinokurig vinokurig reopened this Mar 18, 2024
@vinokurig
Copy link
Contributor

@ibuziuk
Copy link
Member

ibuziuk commented Apr 9, 2024

@vinokurig this was fixed for 7.85.0 / 3.14 right?

@vinokurig
Copy link
Contributor

@ibuziuk

this was fixed for 7.85.0 / 3.14 right?

Yes, do you think we need to cherry-pick this to 7.84?

@ibuziuk
Copy link
Member

ibuziuk commented Apr 10, 2024

I think it should be ok not to cherry-pick it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants