Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Git Services tab duplicates status icon if 2 GitHubs configured #22971

Closed
vinokurig opened this issue May 20, 2024 · 0 comments · Fixed by eclipse-che/che-dashboard#1121 or eclipse-che/che-dashboard#1127
Assignees
Labels
area/dashboard area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@vinokurig
Copy link
Contributor

vinokurig commented May 20, 2024

Describe the bug

If two GitHub aouth configuration secrets are set up, and if authorization agreement is accepted for only one GitHub provider, the authorization status icon is duplicated for both GitHub oauth provider items in the dashboard Git Services tab.

Che version

7.86@latest

Steps to reproduce

  1. Configure 2 GitHub oauth secrets.
  2. Start a workspace from any configured GitHub repository with a devfile, accept the authorization agreement.
  3. Go to Dashboard -> User Preferences -> Git Services, see:

The authorization status is duplicated for both items:
screenshot-eclipse-che apps rosa frmk4-wcwdq-vmd zp2m p3 openshiftapps com-2024 05 20-13_29_18

Expected behavior

The authorization status must be applied per git provider item separately.

Runtime

OpenShift

Screenshots

No response

Installation method

chectl/next

Environment

macOS

Eclipse Che Logs

No response

Additional context

The revoke action is applied for the correct provider item and is hidden for the other provider which is expected.

@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts area/dashboard labels May 20, 2024
@RomanNikitenko RomanNikitenko added the severity/P1 Has a major impact to usage or development of the system. label May 20, 2024
@RomanNikitenko RomanNikitenko changed the title Dashboard Git Services tab duplicates status icon if 2 GitHubs cunfigured Dashboard Git Services tab duplicates status icon if 2 GitHubs configured May 20, 2024
@vinokurig vinokurig self-assigned this May 28, 2024
@ibuziuk ibuziuk reopened this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/git/oauth-services OAuth support to authenticate developers with their GitHub, GitLab, Bitbucket etc...accounts kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
Status: ✅ Done
3 participants