Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a new workspace with a clone of the specified branch doesn't work correctly if repo doesn't have devfile.yaml #23007

Closed
SkorikSergey opened this issue Jun 12, 2024 · 1 comment · Fixed by eclipse-che/che-server#702
Assignees
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.

Comments

@SkorikSergey
Copy link
Contributor

Describe the bug

Starting a new workspace with a clone of the specified branch doesn't work correctly if repo doesn't have devfile.yaml.

Che version

7.87@latest

Steps to reproduce

  1. Start a new workspace with a clone of the specified branch, for example from https://github.com/eclipse-che/che/tree/assets.

Expected behavior

Che repo on assets branch

Runtime

OpenShift

Screenshots

Selection_011
Selection_012

Installation method

chectl/latest

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@SkorikSergey SkorikSergey added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 12, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 12, 2024
@olexii4
Copy link
Contributor

olexii4 commented Jun 12, 2024

@ibuziuk It is a regression after dropping the Devfile V1 support and removing the devfile-converter package eclipse-che/che-dashboard#1090.

It happens because che-server still returns Devfile V1 with the proper branch for a project:
Знімок екрана 2024-06-12 о 17 56 26

But che-dashboard lost the ability to convert Devfile V1 into Devfile V2 without the devfile-converter package and using just a default Devfile.

I am sure that we should fix it on the che-server side. WDYT?

@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. area/che-server and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 12, 2024
@ibuziuk ibuziuk assigned vinokurig and unassigned olexii4 Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-server kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
Status: ✅ Done
5 participants