Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Parametrise workspace folder mount options #2692

Closed
Spritekin opened this issue Oct 4, 2016 · 1 comment
Closed

Request: Parametrise workspace folder mount options #2692

Spritekin opened this issue Oct 4, 2016 · 1 comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@Spritekin
Copy link

This issue has been discussed at: #2565

Summary:
The distinct Che folders (workspace, lib, storage) are mounted by the Che server into the workspace containers using a docker "Z" option (used to declare a folder to be shared by multiple containers). This flag is hardcoded in the Che server code and was added to solve mounting problems in RHEL.

Unfortunately, this flag doesn't play nice with NFS folders. When an NFS folder is used the Z flag causes an error preventing the workspace to be launched. This effect was tested on CoreOS 1122.2, with both a standard NFS and an AWS EFS. Test details in the ticket mentioned above.

Request:
Allow the workspace mount flags (specifically the Z flag) to be configured by a Che server starting parameter (proposed parameter name is --shared_workspace_folder=true).
This parameter will be on by default so Che will default to the current operation. However, the parameter will allow the user to disable the Z share flag.

@ghost ghost added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 4, 2016
@TylerJewell
Copy link

We now allow multiple volume mounts to be configured as a property within Che. Those same volume mounts are then available across all of the che workspaces generated from that initial server. So I think we would need to allow for a set of volume mount properties to be defined in a single location and then reused.

We could, for example, let the volume properties be defined as a string.
che.machine.volume.mount.options="Z,ro"
which would allow for both the shared option along with read only.

A user could set che.machine.volume.mount.options= as a way to remove any flags that we provide as a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

2 participants