Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for intelligent commands #4295

Closed
11 of 12 tasks
slemeur opened this issue Mar 2, 2017 · 2 comments
Closed
11 of 12 tasks

Improvements for intelligent commands #4295

slemeur opened this issue Mar 2, 2017 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 2, 2017

Goals

The goal of this issue is to polish intelligent commands UX and UI.

UI improvements

  • Stretch the command toolbar
    At this moment the command toolbar is using a fixed width.

screen shot 2017-03-01 at 17 08 00

We need to make it using all the width available
  • Previews button

  • We need to resize the preview button so that it has the same size than the other buttons "Run", "Debug".

  • We also need to increase the size of the preview icon

  • We need to add a tooltip when hovering the preview button "Previews"

  • Buttons behaviors

  • We have some insconsistency in the mouse pointer icon which is used accross the different buttons. We need to make sure to use the little hand on all of the buttons "Run", "Debug", "Preview" and all over the command toolbar.
    mouse-pointers

  • We also need to put feedback when hover and manage clicked state:

screen shot 2017-03-02 at 15 22 48

  • Fix position of the leftsidebar icon button
    It must vertically centered in the menubar

screen shot 2017-03-02 at 15 23 21

  • Fix styles of command type selector

screen_shot_2017-03-02_at_10_13_08

Remove the border
  • Fix color of Java icon

screen shot 2017-03-02 at 10 13 22

Use color #B6BABD

UX Improvements

  • Improve context selection

screen shot 2017-03-02 at 16 52 51

  • We need to remove the "Context: workspace"
  • Replace "Projects" title by "Apply to"
  • By default, all projects are "applicable" (means - applicable to all projects of the workspaces)
  • User can disable the projects in which the command is not applicable
  • If a command is not applicable for any project, then it's store in the workspace, visible from command explorer, but not displayed from "run" or "debug" buttons and not available in command palette.
  • When a new project is added into the workspace, the command is applicable for it.
  • When a new command is created, it is applicabled to all existing projects

Other improvements are mostly based on first time experience reports

  • When create a new command, open it at the top of the form
    Today, when you create a new command, it automatically scrolls to the bottom of the form. We need to stay at the top.

  • Improve experience when no command exist in workspace
    When there are no commands configured in the workspace, the user is not guided into the flow of creating a command. We need to help him to understand how it works and how he can configure his workspace's commands.

  • When, there are no commands configured in the workspace: the command toolbar will display " Create and start command." when clicked, it will open the "Commands Explorer" with the editor open to create a new command with goal "Run"

  • When, there are no commands configured in the workspace: When clicking on the "Run" button, it will show this:

screen shot 2017-03-02 at 15 32 52

When clicked, it will open the "Commands Explorer" with the editor open to create a new command with goal "Run"
  • When, there are no commands configured in the workspace: When clicking on the "Debug" button, it will show this:

screen shot 2017-03-02 at 15 33 45

When clicked, it will open the "Commands Explorer" with the editor open to create a new command with goal "Debug"
  • Fix complexity to find where to execute the command from the editor:

screen shot 2017-03-02 at 15 45 29

  • Add button to display command palette
    At first, it is difficult to understand how to get the command palette. We need to add a button in the toolbar so that the commands are easier to find. When clicked, we will display the Command palette.
    We need an tooltip which will also display the keyboard shortcut to display the command palette.

screen shot 2017-03-02 at 16 06 21

  • Add hint in command palette for how to execute a command and keyboard navigation

screen shot 2017-03-02 at 16 47 27

  • Remove 'v' arrow from command toolbar when there is 0 or 1 command running and disable unfolding the list
@slemeur slemeur added the kind/enhancement A feature request - must adhere to the feature request template. label Mar 2, 2017
@azatsarynnyy azatsarynnyy self-assigned this Mar 3, 2017
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Mar 3, 2017
@slemeur
Copy link
Contributor Author

slemeur commented Mar 8, 2017

We need to define keyboard shortcuts to trigger the default "Run" and "Build" commands too.

@slemeur
Copy link
Contributor Author

slemeur commented Mar 9, 2017

Linking with #4380

@azatsarynnyy azatsarynnyy added status/pending-merge and removed status/in-progress This issue has been taken by an engineer and is under active development. status/pending-merge labels Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants