Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme- the blue text in a css file isn't correctly visible against the black background. #7257

Closed
arunkumar413 opened this issue Nov 8, 2017 · 8 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@arunkumar413
Copy link
Contributor

arunkumar413 commented Nov 8, 2017

Description

I'm using trying to edit a .css file using the dark theme in the editor. However the CSS attributes are in blue color and aren't correctly visible against the theme's dark black background. Could you please change this to some other color or guide me to the file of the theme so that I can edit and push my suggestion.

darktheme

Thanks,
Arun

@slemeur slemeur added the kind/question Questions that haven't been identified as being feature requests or bugs. label Nov 8, 2017
@slemeur
Copy link
Contributor

slemeur commented Nov 8, 2017

We built-in editor in Che is Orion at this moment but we are looking to move to Monaco in near future (#5330).

For the time being, we have some documentation about adding a new syntax highlighting : https://www.eclipse.org/che/docs/assemblies/sdk-code-editors/index.html#syntax-highlighting

We unfortunately don't have docs on how to edit an existing highlighting configuration.
@ashumilova Could you guide @arunkumar413 ?

@ashumilova
Copy link
Contributor

Hi, @arunkumar413
There is set of styles that override the orion default ones - https://github.com/eclipse/che/blob/master/ide/che-core-orion-editor/src/main/resources/org/eclipse/che/ide/editor/orion/client/orion-codenvy-theme.css
here nothing for overriding the css file types was added, so such files are not properly handled by IDE application in the Dark Theme. To do that - you' ll need to edit mentioned above css file by adding proper styles.
I can provide you the class names: support type propertyName css
You can see it from the following screenshot:
screenshot from 2017-11-09 11-49-16

@arunkumar413
Copy link
Contributor Author

Hi @ashumilova ,

Thanks a lot. I'm not able to push the changes to the master and also not able to create my own branch. Please help. I'd like to add this snippet to the css file.

.support type propertyName css{
       color: #00bcd4;
    }

@skabashnyuk
Copy link
Contributor

@arunkumar413 are you doing that in your fork?

@arunkumar413
Copy link
Contributor Author

No, I'm trying to push to the master of this respository

@skabashnyuk
Copy link
Contributor

skabashnyuk commented Nov 10, 2017

you can't do that if you are not Eclipse Che commiter. You can do it in your personal fork.

@arunkumar413
Copy link
Contributor Author

If I do it in my personal fork will the changes reflect in the master branch of this repository.

@skabashnyuk
Copy link
Contributor

Yes, when you'll create PR https://help.github.com/articles/creating-a-pull-request/ will see it.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

4 participants