Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Servers delivery mechanism #7554

Closed
3 tasks done
gazarenkov opened this issue Nov 24, 2017 · 3 comments
Closed
3 tasks done

Language Servers delivery mechanism #7554

gazarenkov opened this issue Nov 24, 2017 · 3 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@gazarenkov
Copy link
Contributor

gazarenkov commented Nov 24, 2017

Goal: to implement and document mechanism for LS delivery using Che entities which:

  • Is unified and documentable
  • Use LS written by third party provider using any language (define and well-document possible conditions and limitations)
  • Support LS deployed in standalone container usecase.

Presumably LS will be:

  • declared as a Workspace's Server with meta-information enough to identify it as an LS, identify language(s) it serves etc
  • Pre-deployed as a software inside image or an installation script inside recipe script or Che installer (as usual Server so)
  • Normally be accessible from other machines (containers) running in WS
  • accessible from outside via dedicated (proxying) server(s), not directly (to be able to combine LS-es and to give the access only via Che's authorization system)

So, to add Language Server one needs to add it as a Che Server with special set of attributes, like:

  • languageServer=[languages]
  • watchDirectories=[paths]
  • matchPatterns=[regexps]

Subissues to implement:

@slemeur
Copy link
Contributor

slemeur commented Nov 27, 2017

@gazarenkov : We already have an epic for that: #6792

@slemeur slemeur changed the title Language Servers delivery mechanism Document Language Servers delivery mechanism Nov 28, 2017
@slemeur slemeur added kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. labels Nov 28, 2017
@gazarenkov gazarenkov changed the title Document Language Servers delivery mechanism Language Servers delivery mechanism Nov 28, 2017
@tsmaeder
Copy link
Contributor

Why would the language servers be accessible from outside the workspace?

@garagatyi
Copy link

It won't. We will add internal server concept that may be treated by the infra in some special way. In case of Docker, it will be accessible from the workspace docker network only. Pretty the same behavior will be used for OpenShift (access by Service, not Route).

@gazarenkov gazarenkov added kind/enhancement A feature request - must adhere to the feature request template. and removed kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

6 participants