OpenShift multi-container workspace fails to start

[sleshchenko]

Description

OpenShift multi-container workspace fails to start. It happens because of wrong resolving machine servers when containers are located in one Pod.

Reproduction Steps

1. Create a workspace with the following OpenShift multi-container workspace configuration:

Workspace Config

{
  "environments": {
    "default": {
      "machines": {
        "ws/typescript-ls": {
          "servers": {
            "ls": {
              "attributes": {
                "internal": "true",
                "type": "ls",
                "config": "{\"id\":\"org.eclipse.che.plugin.web.typescript\", \"documentFilters\":[  {  \"languageId\":\"typescript\",  \"pathRegex\":\".*\\\\.(ts|tsx)\"} ]}"
              },
              "port": "4417",
              "protocol": "tcp"
            }
          },
          "volumes": {
            "projects": {
              "path": "/projects"
            }
          },
          "installers": [],
          "env": {}
        },
        "ws/dev": {
          "attributes": {},
          "servers": {
            "codeserver": {
              "attributes": {},
              "port": "9876",
              "protocol": "http"
            }
          },
          "volumes": {
            "projects": {
              "path": "/projects"
            }
          },
          "installers": [
            "org.eclipse.che.exec",
            "org.eclipse.che.terminal",
            "org.eclipse.che.ws-agent"
          ],
          "env": {}
        }
      },
      "recipe": {
        "type": "openshift",
        "content": "---\nkind: List\nitems:\n-\n  apiVersion: v1\n  kind: Pod\n  metadata:\n    name: ws\n  spec:\n    containers:\n      -\n        image: eivantsov/tsls\n        name: typescript-ls\n      -\n        image: eclipse/ubuntu_jdk8\n        name: dev",
        "contentType": "application/x-yaml"
      }
    }
  },
  "defaultEnv": "default",
  "projects": [
    {
      "links": [],
      "name": "greeter",
      "attributes": {},
      "type": "typescript",
      "source": {
        "location": "https://github.com/Microsoft/TypeScriptSamples.git",
        "type": "git",
        "parameters": {
          "convertToTopLevelProject": "true",
          "keepVcs": "false",
          "keepDir": "greeter"
        }
      },
      "path": "/greeter",
      "problems": [],
      "mixins": []
    }
  ],
  "name": "TypeScript_LS_Demo",
  "commands": [],
  "links": []
}

2. Try to start the created workspace.

Expected: Workspace is started.
Actual: Workspace failed to start

So, as we can see the configuration of ws/typescript-ls doesn't have wsagent installer, but its runtime contains wsagent/http server. It leads to workspace start failing because Che Server waits until all machine's servers will be available.

Get workspace by Response

OS and version:
Che 6.0.0-M4-SNAPSHOT

Diagnostics:

[gazarenkov]

Yes, it is weird bug as it seems nothing tells that there is wsagent/http server.