Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ws-agent activity notification mechanism #9126

Closed
akorneta opened this issue Mar 19, 2018 · 1 comment
Closed

Rework ws-agent activity notification mechanism #9126

akorneta opened this issue Mar 19, 2018 · 1 comment
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@akorneta
Copy link
Contributor

Description

In cases when notification scheduler does not notify about activity till the current time >= last update time + threshold then the activity notification will be sent in the same thread in which this activity occurred. Such behaviour may lead to problems because the request for activity has default timeout 1 minute, and if the master is not available for this period it will block the activity thread for one minute. The activity thread its tomcat thread where LastAccessTimeFilter call WorkspaceActivityNotifier.onActivity(), and during this period the client won't receive a response from the agent.

The problem is not abstract, it occurs while recovery on docker infrastructure.

  • on post-construct ws-master recovers runtime
  • then checks servers with request timeout 3 sec
  • server checks produce activity and wait for 3 sec till agent notifies about activity master(master) in the same thread after timeout is exceeded server checks fail and workspaces considered as stopped.
@akorneta akorneta added kind/bug Outline of a bug - must adhere to the bug report template. team/platform labels Mar 19, 2018
@sleshchenko sleshchenko added the severity/P1 Has a major impact to usage or development of the system. label May 8, 2018
@artaleks9
Copy link
Contributor

Still actual for ver.6.5.0

@mkuznyetsov mkuznyetsov self-assigned this May 14, 2018
@mkuznyetsov mkuznyetsov added the status/in-progress This issue has been taken by an engineer and is under active development. label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

4 participants