Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/https proxy ENV in helm chart #9549

Closed
bcg62 opened this issue Apr 26, 2018 · 6 comments
Closed

http/https proxy ENV in helm chart #9549

bcg62 opened this issue Apr 26, 2018 · 6 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@bcg62
Copy link

bcg62 commented Apr 26, 2018

currently it looks like there's no way to apply proxy settings, or additional env vars in general to the deployment.

simple things like:
command: ["sh", "-c", "apk --no-cache add curl.... will fail in a cluster that does not have direct internet access

@ghost ghost added kind/bug Outline of a bug - must adhere to the bug report template. team/platform severity/P1 Has a major impact to usage or development of the system. labels Apr 26, 2018
@ghost
Copy link

ghost commented Apr 26, 2018

@bcg62 yes, currently OpenShift and Kubernetes infras lack this feature.

@skabashnyuk I label this as a bug, since OpenShift/K8S cluster behind a proxy will be a common use case. While Docker infra implementation handles it OK, we should think of doing the same in OpenShift/K8S:

  1. Add http_proxy, https_proxy and no_proxy to Che server, Keycloak and workspace containers.
  2. Add JVM args for Che server and workspace agent.

@artaleks9
Copy link
Contributor

Still actual for ver.6.6.0

@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. kind/bug Outline of a bug - must adhere to the bug report template. labels Jun 4, 2018
@slemeur
Copy link
Contributor

slemeur commented Jun 4, 2018

@eivantsov : I think you have a way to handle this. Has this been added to the documentation?

@ghost
Copy link

ghost commented Jun 4, 2018

@slemeur no, not in docs yet. It felt somewhat wrong to document it, so I hoped some automation on server side was possible.

@ghost
Copy link

ghost commented Jun 18, 2018

So, this is both a docs and eng task.

As the moment, the following envs work for Docker infra only:

CHE_WORKSPACE_HTTP__PROXY
CHE_WORKSPACE_HTTPS__PROXY
CHE_WORKSPACE_NO__PROXY

We need env provisioners for them. Once done, I can summarize in docs all the proxy envs that a user might need.

@ghost
Copy link

ghost commented Jul 25, 2018

Will be fixed by #10387

@ghost ghost closed this as completed Jul 25, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants