Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New plugin model doesn't work in electron version of Theia #9767

Closed
mmorhun opened this issue May 22, 2018 · 1 comment · Fixed by eclipse-theia/theia#2262
Closed

New plugin model doesn't work in electron version of Theia #9767

mmorhun opened this issue May 22, 2018 · 1 comment · Fixed by eclipse-theia/theia#2262
Assignees
@evidolob
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/branch Indicates that a PR will be merged into a branch other than master.

Comments

@mmorhun
Copy link
Contributor

mmorhun commented May 22, 2018

Description

Hosted plugin doesn't work electron mode with many similar errors like the following:

Uncaught (in promise) ReferenceError: setImmediate is not defined
    at RPCMultiplexer.../../packages/plugin-ext/lib/api/rpc-protocol.js.RPCMultiplexer.send (rpc-protocol.ts:230)
    at rpc-protocol.ts:134
    at <anonymous>

Reproduction Steps

Start electron version of Theia with a hosted plugin. See debug console for errors.
@mmorhun mmorhun added kind/bug Outline of a bug - must adhere to the bug report template. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/branch Indicates that a PR will be merged into a branch other than master. team/ide2 labels May 22, 2018
@ashumilova ashumilova added the severity/P1 Has a major impact to usage or development of the system. label Jun 14, 2018
@ashumilova ashumilova mentioned this issue Jun 15, 2018
Closed
18 tasks
@benoitf
Copy link
Contributor

benoitf commented Jun 21, 2018

electron/electron#2984 (settimeout)

@benoitf benoitf mentioned this issue Jun 27, 2018
Closed
@evidolob evidolob self-assigned this Jun 29, 2018
@evidolob evidolob added the status/in-progress This issue has been taken by an engineer and is under active development. label Jun 29, 2018
@evidolob evidolob mentioned this issue Jul 4, 2018
Merged
@ashumilova ashumilova removed the status/in-progress This issue has been taken by an engineer and is under active development. label Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evidolob evidolob

Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. status/open-for-dev An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[plugin-ext] Fix plugin api in electron packaging eclipse-theia/theia
4 participants
@benoitf @evidolob @ashumilova @mmorhun