Update plugin brokers to v3.4.0 #17870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update brokers to v3.4.0 to enable plugin merging. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
che-bot
added
status/code-review
tolusha
approved these changes
Sep 15, 2020
JPinkney
approved these changes
Sep 15, 2020
sleshchenko
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
Is it an egg or hen that was the first?)
Probably happy path test should read value from che.properties and propagate to che operator... Otherwise it does not test changes correctly. The same could be faced with jwtproxy, pvc job and maybe others images. Could you create an issue for QE or deploy team to investigate it?
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
che-bot
removed
the
status/code-review
This was referenced Sep 15, 2020
|
@sleshchenko Created issue #17871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just updates the plugin brokers to version 3.4.0 to avoid an issue with happy path tests:
This makes it difficult to merge PRs like #17785 that update the broker and adapt Che to use it in one changeset.
Functionally, nothing is changed with the PR as added functionality in v3.4.0 (plugin merging) is enabled via flag.
What issues does this PR fix or reference?
Necessary for #15373