feat: Support missing instruction #113
Conversation
| add_machine_instr(result, "VNN", mach_format::VRR_c, { vec_reg_4_U, vec_reg_4_U, vec_reg_4_U }, 48, 1574); | ||
| add_machine_instr(result, "VNO", mach_format::VRR_c, { vec_reg_4_U, vec_reg_4_U, vec_reg_4_U }, 48, 1574); | ||
| add_machine_instr(result, "VNN", mach_format::VRR_c, { vec_reg_4_U, vec_reg_4_U, vec_reg_4_U }, 1574); | ||
| add_machine_instr(result, "VNO", mach_format::VRR_c, { vec_reg_4_U, vec_reg_4_U, vec_reg_4_U }, 1574); | ||
| result.insert(std::pair<const std::string, machine_instruction_ptr>("VNOT", |
There was a problem hiding this comment.
I am wondering about this mnemonic. As far as I can tell VNOT has two operands VNOT A,B which is expanded into VNO A,B,B instruction. Yet the plugin requires three arguments at the moment.
There was a problem hiding this comment.
Yes, you are correct. But , this was something pre-existing in the plugin where it takes 3 arguments and wants 2nd and 3rd operands to be equal. I am not sure why it was done this way ?
Maybe @michalbali256 remembers something about it
There was a problem hiding this comment.
So VNOT is actually a mnemonic? It must have been originally misunderstood... We can either keep VNOT as an instruction and just edit its format, or create a mnemonic - slight problem being, that we do not have a way to copy second operand and use it as third. However, we can just substitute third operand with zero, which will always be valid. At the same time, the second operand will still be checked so the user will not know.
Either way, class vnot_instruction can be removed.
…d operand value as 0 Signed-off-by: Sweta Shah <swetas04@gmail.com>
-m "ignored file"
-s -m "local git ignore file removed"
Signed-off-by: Sweta Shah <swetas04@gmail.com>
…AS04/che-che4z-lsp-for-hlasm into Support_missing-instruction
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.13.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR includes new instruction mnemonics and the modified ones that have been added to the new Z15 and support for missing ones in the previous version.