refactor: Split complex classes #134
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
| @@ -31,6 +31,13 @@ class parser_error_listener_ctx : public diagnosable_ctx, public parser_error_li | |||
| : diagnosable_ctx(hlasm_ctx) | |||
| , parser_error_listener_substitution(add_diag_with_ctx, substituted, std::move(provider)) | |||
| {} | |||
| parser_error_listener_ctx(context::hlasm_context& hlasm_ctx, | |||
There was a problem hiding this comment.
Why would I want to use this overload instead of parser_error_listener_substitution? It completely bypasses the added value of context.
| parsing::parser_error_listener_ctx listener(*m_ctx->hlasm_ctx, nullptr); | ||
| listener.add_diagnostic( | ||
| diagnostic_op::error_E001(range { { line_no, 0 }, { line_no, s.code_offset_utf16 } })); | ||
| collect_diags_from_child(listener); |
There was a problem hiding this comment.
Why not make opencode_provider inherit from diagnosable_ctx? Then these lines would be just:
| parsing::parser_error_listener_ctx listener(*m_ctx->hlasm_ctx, nullptr); | |
| listener.add_diagnostic( | |
| diagnostic_op::error_E001(range { { line_no, 0 }, { line_no, s.code_offset_utf16 } })); | |
| collect_diags_from_child(listener); | |
| add_diagnostic( | |
| diagnostic_op::error_E001(range { { line_no, 0 }, { line_no, s.code_offset_utf16 } })); |
| workspaces::parse_lib_provider& lib_provider, | ||
| processing::processing_state_listener& state_listener, | ||
| semantics::source_info_processor& src_proc, | ||
| const std::string& filename, |
There was a problem hiding this comment.
I am not 100% sure about this, but context has method opencode_file_name, probably could replace this parameter.
There was a problem hiding this comment.
there appear to be cases when we are passing both the context and the filename as parameters and at the moment I am not 100% convinced that they always match.
|
🎉 This PR is included in version 0.14.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
refactor: parser_impl split
refactor: EOLLN mechanism replaced by true per logical line parsing
fix: apostrophe in strings may be incorrectly reparsed
fix: reparse stops at NUL characters
fix: ignore diags and highlighting info in the lookahead mode
fix: correctly diagnose invalid line continuations
fix: crash on an invalid instruction in the lookahead mode
fix: follow argument restrictions of isspace, isaplha etc.
feat: Lines processed by AREAD are highlighted as such
test: hover over non-existent macro
refactor: unify analyzer options
fix: handle empty variables and concatenations in the label