feat: USING and DROP support #230
Conversation
…9331dfc1609fc5f459)
| result.reg_offset -= min_disp; | ||
| else /* if (result.reg_offset > max_disp) */ | ||
| result.reg_offset -= max_disp; |
There was a problem hiding this comment.
I'm not sure what these two assignments should represent so my question might be irrelevant.
Nevertheless, it seems that when the result.reg_offset < min_disp the min_disp is subtracted from result.reg_offset. Shouldn't it be the other way around? Isn't the end goal to have result.reg_offset in the range <min_disp, max_disp>?
There was a problem hiding this comment.
I've been considering adding a union with something like out_of_range_by... because that's what it means when the mapping register set consists of invalid registers.
There was a problem hiding this comment.
I like this idea! Maybe it can be a feature for one of the next PRs
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 1.1.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implements USING and DROP
PUSH and POP USING
Ordinary, labeled, dependent USINGs
Integration with checker in a separate PR