Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: TI review of wiki pages and updates to readme files #56

Merged
merged 41 commits into from
Jul 7, 2020

Conversation

zeibura
Copy link
Contributor

@zeibura zeibura commented Jun 1, 2020

Not finished yet, creating this so that I can keep track of work done so far.

  • Docs files up to "home.md" are finished. I'm not sure if "home.MD" needs to be proofread as it is still formatted in MediaWiki rather than in Markdown. To resume tomorrow from "libraries configuration"
  • Some changes have been made to the new readme content and the readme structure (the bottom section split into two subsections and renamed configuring, as hinted by the link in a section above)
  • A few minor changes to Changelog.MD

@michalbali256
Copy link
Contributor

I'm not sure if "home.MD" needs to be proofread as it is still formatted in MediaWiki rather than in Markdown.

The whole documentation is published on GitHub wiki, for which are the MediaWiki references preferable over markdown references (I am not 100% sure, but I think markdown references required full url to target).

@zeibura
Copy link
Contributor Author

zeibura commented Jun 2, 2020

The whole documentation is published on GitHub wiki, for which are the MediaWiki references preferable over markdown references (I am not 100% sure, but I think markdown references required full url to target).

Relative paths work too in Markdown, but in MW you just need the page title.

I am a bit confused then, since the rest of the pages are formatted in markdown, only home.MD is in mediawiki (and the mediawiki links don't show up properly)

@michalbali256
Copy link
Contributor

All pages are formatted in markdown, only links between the pages are written using the MediaWiki syntax. I agree it may be a bit messy but at least for me it easy to use (mainly because I do not know MW syntax).

and the mediawiki links don't show up properly

They don't show up properly when viewing the sources directly, but they show up properly in GitHub wiki - that is the target platform. The docs/ folder is automatically published to wiki after each PR merge.

@zeibura
Copy link
Contributor Author

zeibura commented Jun 2, 2020

OK, thanks for the explanation, I wasn't aware the GitHub wiki could read both formats at once

@zeibura
Copy link
Contributor Author

zeibura commented Jun 2, 2020

All files in the root folder are now done
One rather high level point is that the page title "libraries configuration" should be "configuration of libraries". Unless this will cause any problems, I will move the page as it would be done in MediaWiki, i.e. by renaming it, and then creating a MW redirect at the old title, just in case any links to the old page remain anywhere.

@michalbali256
Copy link
Contributor

Sure, go ahead with the renaming. I don't see any problems it will cause.

@zeibura zeibura requested review from michalbali256 and asmelko June 11, 2020 13:09
@zeibura
Copy link
Contributor Author

zeibura commented Jun 11, 2020

All pages are done

Copy link
Contributor

@michalbali256 michalbali256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you did a great job, thanks. I am sending several suggestions, mostly to get rid of double headings in wiki that I left there.

docs/Analyzer-pages/HLASM-context-tables.md Outdated Show resolved Hide resolved
docs/Analyzer-pages/Instruction-format-validation.md Outdated Show resolved Hide resolved
docs/Extension.md Outdated Show resolved Hide resolved
docs/HLASM-overview.md Outdated Show resolved Hide resolved
docs/Language-server-pages/LSP-and-DAP-server.md Outdated Show resolved Hide resolved
docs/Language-server-pages/Request-manager.md Outdated Show resolved Hide resolved
zeibura and others added 7 commits June 18, 2020 10:11
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
Co-authored-by: Michal Bali <38988507+michalbali256@users.noreply.github.com>
@zeibura
Copy link
Contributor Author

zeibura commented Jun 18, 2020

Thansk! Just FYI, MediaWiki pipe links are [[target|link text]], not [[link text|target]]. I fixed one more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@michalbali256 michalbali256 changed the title TI review of wiki pages and updates to readme files docs: TI review of wiki pages and updates to readme files Jul 7, 2020
@michalbali256 michalbali256 merged commit e66ea4a into development Jul 7, 2020
@michalbali256 michalbali256 deleted the TI-review branch July 7, 2020 13:22
@github-actions
Copy link

🎉 This PR is included in version 0.12.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

SWETAS04 pushed a commit to SWETAS04/che-che4z-lsp-for-hlasm that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants