Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXRL instruction flagged as error by plugin #57

Closed
cybersorcerer opened this issue Jun 3, 2020 · 1 comment · Fixed by #121
Closed

EXRL instruction flagged as error by plugin #57

cybersorcerer opened this issue Jun 3, 2020 · 1 comment · Fixed by #121
Labels
bug Something isn't working

Comments

@cybersorcerer
Copy link

cybersorcerer commented Jun 3, 2020

Hi guys,

have a look at the following code fragment:

*-B E G I N-----------------------------------------------------------*
*  Move command from CIB to internal buffer                           *
*---------------------------------------------------------------------*
             MVIY  CMDBUFF,C' '              Clear command buffer
             MVC   CMDBUFF+1(L'CMDBUFF-1),CMDBUFF
             LAY   R1,CMDBUFF                Load command pointer$02$06
             LAY   R2,CIBDATA                  Load A(MODIFY/F data). $06
             BCTR  R3,0                             Decrement it for MVC.
             EXRL  R3,MVCEX                    Changed to EXRL        $06
*-E N D---------------------------------------------------------------*
*  Move command from CIB to internal buffer                           *
*---------------------------------------------------------------------*
              .
              .
MVCEX  MVC   0(0,R1),0(R2)                 Move command to internal

The EXRL instruction above is perfectly valid. MVCEX is a label in code. EXRL is of format RIL-b and available since z10. MVCEX in the instruction is converted to the number of halfwords distance between the EXRL instruction address and the MVCEX label.
The plugin marks this instruction with the following error:

Error at EXRL instruction: operand must be an absolute immediate value"

This is wrong and should be fixed!

  • Editor: VS Code/Theia 1.45.1
  • OS: Windows 10 64-Bit
  • Plugin version: 0.11.0

greetings

Ronny

@michalbali256 michalbali256 added the bug Something isn't working label Jun 3, 2020
@fox0r fox0r added this to the 0.13.0 milestone Jun 22, 2020
@fox0r fox0r modified the milestones: 0.13.0, 0.12.0 Jul 16, 2020
@marcel1hruska marcel1hruska linked a pull request Aug 4, 2020 that will close this issue
@michalbali256 michalbali256 removed this from the 0.12.0 milestone Jun 9, 2021
@slavek-kucera slavek-kucera linked a pull request Jul 7, 2021 that will close this issue
@slavek-kucera
Copy link
Contributor

Resolved in release 0.14.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants