refactor: Refactor of attribute lookahead processing #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add method that prepares for building expr tree
parser_library/src/context/ordinary_assembly/ordinary_assembly_context.cpp
Show resolved
Hide resolved
| void ordinary_assembly_context::add_symbol_reference(symbol sym) | ||
| { | ||
| auto name = sym.name; | ||
| symbol_refs_.try_emplace(name, std::move(sym)); |
There was a problem hiding this comment.
I still think that the copy is not needed. But this code will make two copies...
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 0.12.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.12.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SWETAS04
pushed a commit
to SWETAS04/che-che4z-lsp-for-hlasm
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until the PR, attribute lookahead was triggered during evaluation of CA expressions. That caused a complexity on the parser as it needed to be prepared to start parsing (performing lookup) in the middle of any statement processing.
The PR introduces new method of performing attribute lookup. It separates lookup from statement processing by initiating the lookup before a statement is passed to a processor.
The refactor caused the simplification of
parser_implandcollectorclasses. Also it moved the functionality of lookup fromprocessing_managertostatement_providerwhile utilizing theprocessing_manager's loop.The refactor may simplify the future work in parsing optimizations.