Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Windows warning CMP0115 #741

Closed
emersonknapp opened this issue Apr 1, 2021 · 5 comments
Closed

CMake Windows warning CMP0115 #741

emersonknapp opened this issue Apr 1, 2021 · 5 comments

Comments

@emersonknapp
Copy link

This is making the ROS2 buildfarm go yellow on the nightlies - see for example https://ci.ros2.org/view/nightly/job/nightly_win_deb/1943/consoleText

The warning output is as follows

CMake Warning (dev) at src/idl/CMakeLists.txt:41 (add_library):
  Policy CMP0115 is not set: Source file extensions must be explicit.  Run
  "cmake --help-policy CMP0115" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  File:

    C:/ci/ws/src/eclipse-cyclonedds/cyclonedds/src/idl/src/hashid.c.in
This warning is for project developers.  Use -Wno-dev to suppress it.
@eboasson
Copy link
Contributor

eboasson commented Apr 2, 2021

@k0ekk0ek just from the name of the file involved I think this relates to #735. Are you ok with me leaving it for you to look into in more detail?

@k0ekk0ek
Copy link
Contributor

@eboasson, absolutely, but I missed the notification. I'll have a go at it.

@k0ekk0ek
Copy link
Contributor

I think this particular issue is fixed by #737. Looking at the description provided in #756, I think CMake previously searched for hashid.c and found hashid.c.in. The error of course being it should use the generated version. I've tried to reproduce locally with CMake 3.20, but the warning didn't occur. The warning also isn't in the latest ROS builds, so I think we can safely close this. @emersonknapp, do you agree?

@emersonknapp
Copy link
Author

Yep, this was opened to make ROS builds green - I don't have any particular input beyond that :)

@k0ekk0ek
Copy link
Contributor

Closing this issue. Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants