Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Roles - Duplicated permission checks. #4614

Open
TIVMOF opened this issue Feb 4, 2025 · 0 comments
Open

[UI] Roles - Duplicated permission checks. #4614

TIVMOF opened this issue Feb 4, 2025 · 0 comments

Comments

@TIVMOF
Copy link
Contributor

TIVMOF commented Feb 4, 2025

Currently, roles are managed from two separate places in the same manner. Both service files and extension files define roles:

  • Extension files can have only one role.
  • Service files can have a list of roles.

The permission checks occur in two separate places—one for services and one for extensions. However, in most cases, the roles in both locations are the same.

Current Role Handling:

  • 1. Through Extensions

The ExtensionService (located in components/core/core-extensions) verifies if a user has the appropriate role to access an extension.

Extension Role Handling

  • 2. Through Service JS Files

The following service files in resources/resources-core/services check if a user has any of the roles listed:

  • views.js
  • perspectives.js
  • menu.js
  • dialog-window.js

Service Role Handling

Next Steps

A discussion is needed to decide which method should be removed or reworked to clarify role handling in Dirigible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant