-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faces 4.0: add <h:inputText type> #1560
Comments
i think we really have to think about this in general. Its very simliar to #1507 Should we continue to always manually add those attributes/events? or should we maybe accept all attributes and render them as passthrought. |
It's not the same. Current ticket is basically:
Other ticket is basically:
|
<h:inputText type> has been added: eclipse-ee4j/mojarra@6733916 Before looking at min/max/step attributes I'm awaiting feedback/objections for
If no feedback nor objections then I won't implement that (but only add the three new attributes). |
I won't add the three new attributes in context of this ticket either. It's going to be a little more involved because people will be expecting server side validation on them and these should technically speaking also be compatible with date types such as |
Add new attribute
<h:inputText type>
to allow HTML5 types such asemail
search
tel
url
number
(along withmin
,max
andstep
attributes)range
(along withmin
,max
andstep
attributes)datetime-local
month
time
week
date
color
https://developer.mozilla.org/en-US/docs/Learn/Forms/HTML5_input_types
NOTE: API may not validate/reject unknown ones as they are essentially extensible. Probably at most in dev stage log a warning when types are used for which a different standard component should be preferred such as
secret
,submit
,file
,hidden
,checkbox
andradio
.Currently already possible and working fine with help of passthrough attributes. But it's better and cleaner if it's directly supported by API.
Moreover, it would particularly on
number
/range
based inputs be totally awesome if anyminimum
andmaximum
attribute of any attached<f:validateXxxRange>
is consulted during render so that it's automatically rendered asmin
andmax
attributes.The text was updated successfully, but these errors were encountered: